Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Triggering Gerrit Trigger Plugin On Change To Sub-Directory

Received: by 10.204.13.69 with SMTP id b5mr1120244bka.4.1334580851180;
        Mon, 16 Apr 2012 05:54:11 -0700 (PDT)
X-BeenThere: repo-discuss@googlegroups.com
Received: by 10.204.136.212 with SMTP id s20ls5081713bkt.2.gmail; Mon, 16 Apr
 2012 05:54:06 -0700 (PDT)
Received: by 10.204.129.15 with SMTP id m15mr1121186bks.2.1334580846688;
        Mon, 16 Apr 2012 05:54:06 -0700 (PDT)
Received: by 10.204.129.15 with SMTP id m15mr1121185bks.2.1334580846673;
        Mon, 16 Apr 2012 05:54:06 -0700 (PDT)
Return-Path: <Gustaf.Lu...@sonymobile.com>
Received: from seldrel01.sonyericsson.com (seldrel01.sonyericsson.com. [212.209.106.2])
        by gmr-mx.google.com with ESMTPS id 8si8804254bka.1.2012.04.16.05.54.06
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 16 Apr 2012 05:54:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of Gustaf.Lu...@sonymobile.com designates 212.209.106.2 as permitted sender) client-ip=212.209.106.2;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of Gustaf.Lu...@sonymobile.com designates 212.209.106.2 as permitted sender) smtp.mail=Gustaf.Lu...@sonymobile.com
From: "Lundh, Gustaf" <Gustaf.Lu...@sonymobile.com>
To: Jason Axelson <jaxel...@referentia.com>, Scott Lavender
	<slaven...@internap.com>
CC: "repo-discuss@googlegroups.com" <repo-discuss@googlegroups.com>
Date: Mon, 16 Apr 2012 14:54:04 +0200
Subject: RE: Triggering Gerrit Trigger Plugin On Change To Sub-Directory
Thread-Topic: Triggering Gerrit Trigger Plugin On Change To Sub-Directory
Thread-Index: Ac0ZzMTHhlob4P/7RVe32UDqieF1UACABwBg
Message-ID: <6B1C9B524D48864D85CCBE1B742C8EE4B06680C04B@seldmbx03.corpusers.net>
References: <c524b9d7-6da7-4886-aeb8-5bfa99c3dbc1@9g2000yqp.googlegroups.com>
 <25435711.182.1334346469531.JavaMail.geo-discussion-forums@vbgj4>
 <20120413202312.GG2653@google.com>
 <CAFULzpaA+wcUV2z9DGAutYq7EsaWr7wpiaeb1rDZiXse4XEMFA@mail.gmail.com>
 <CAC9ii1qTr_uSiLYnURpFiXYp=4KSwmvm2d71wSoVMnqksXGCqw@mail.gmail.com>
In-Reply-To: <CAC9ii1qTr_uSiLYnURpFiXYp=4KSwmvm2d71wSoVMnqksXGCqw@mail.gmail.com>
Accept-Language: en-US, sv-SE
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US, sv-SE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I have a vague memory which tells me that when we developed the " --file" s=
upport for the Gerrit query command (which was needed for this feature to w=
ork in the Gerrit Trigger plug-in), we guessed that the next release of Ger=
rit would be 2.2.3. Hence this would be the first version to support the fi=
le filtering in the Jenkins plug-in.=20

Now, as we now know, the next major release turned out to be Gerrit 2.3 and=
 we ended up with the wrong version warning in Gerrit Trigger plug-in. But =
don't worry, the Gerrit Trigger guys, Robert Sandell and Tomas Westling, ha=
s promised to fix the warning.=20

Note: If you run a -SNAPSHOT build of Gerrit, all features will be enabled =
in the Gerrit Trigger plug-in, since we cannot really know what features ha=
ve been cherry-picked into Gerrit (but with a small warning/notification on=
 the "Manage Jenkins"-page).

/Gustaf

-----Original Message-----
From: repo-discuss@googlegroups.com [mailto:repo-discuss@googlegroups.com] =
On Behalf Of Jason Axelson
Sent: den 14 april 2012 01:25
To: Scott Lavender
Cc: repo-discuss@googlegroups.com
Subject: Re: Triggering Gerrit Trigger Plugin On Change To Sub-Directory

I think that there is a typo in the Gerrit plugin. When it says it
requires 2.2.3 I think it actually needs 2.3 (which was released last
week).

Jason

On Fri, Apr 13, 2012 at 10:27 AM, Scott Lavender <slaven...@internap.com> w=
rote:
> BINGO! I will have to wait on the 2.2.3 release of Gerrit it looks like..=
.
>
> The connected Gerrit's version is a bit old, so not all Gerrit features a=
re
> enabled. The following featured has been disabled:
>
> Trigger on files requires 2.2.3
>
>
> On Fri, Apr 13, 2012 at 4:23 PM, Magnus B=E4ck <ba...@google.com> wrote:
>>
>> On Friday, April 13, 2012 at 15:47 EDT,
>> =A0 =A0 Scott Lavender <slaven...@internap.com> wrote:
>>
>> > This is exactly what the plugin help describes:
>> >
>> > Then you can optionally provide the name of the specific file path(s)
>> > to trigger on. E.g. to only trigger builds if the patch set contains
>> > files in a certain folder. The same "pattern types" are available as
>> > above. If no file paths are added, all files will trigger a build.
>> >
>> > So for example to trigger on all files in any sub-folder called java:
>> >
>> >
>> > =A0 =A0- *Type:* Path
>> > =A0 =A0- *Pattern:* **/java/
>>
>> Okay, so there actually is such a feature. It isn't shown in the GUI
>> examples at https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger
>> so I assumed it didn't exist.
>>
>> However, according to what you write in your original post, you're
>> nevertheless using the branch condition text field when you should be
>> using the text field for file paths. =A0Reading the source code, this
>> feature is only enabled if the Gerrit you're running is sufficiently
>> new (2.2.3+). If it is, there will be a separate set of widgets below
>> the branch selection widgets to allow you to add and delete file paths
>> to trigger on.
>>
>> --
>> Magnus B=E4ck
>> ba...@google.com
>>
>> --
>> To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
>> More info at http://groups.google.com/group/repo-discuss?hl=3Den
>
>
>
>
> --
>
> Scott Lavender |=A0Cloud Release Engineer
> _____________________________________ _______
>
> Phone 678.554.3403 .=A0Cell 770.361.5940
> slaven...@internap.com=A0. www.internap.com
>
> INTERNAP =AE
> connectivity | colocation | managed hosting | cloud
>
> One Ravinia Drive=A0.=A0Suite 1300=A0.=A0Atlanta=A0.=A0GA=A0.=A030346
>
>
> --
> To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=3Den

--=20
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=3Den