No reflog for newly created projects!

45 views
Skip to first unread message

Sasa Zivkov

unread,
Mar 9, 2011, 8:53:52 AM3/9/11
to repo-d...@googlegroups.com
We found that in Gerrit 2.1.6.1 (which is the latest release) reflog is disabled for all newly created projects.
Means: core.logallrefupdates=false

you may not be aware of that same as we were not :-)

This change in Gerrit behavior was introduced by the JGit change ffc8b42957a2f294960d5ad027e2c7e41d3f70cd
which sets core.logallrefupdates to !bare. Means for bare repositories to false.
This is correct according to CGit documentation:
http://www.kernel.org/pub/software/scm/git/docs/git-config.html

however, it is not what Gerrit admins expect from previous behavior.

We will try to provide Gerrit patch for this issue today where we would return to the old behavior
by explicitly setting core.logallrefupdates to true after Git repo is initialized.

Sasa Zivkov

Matthias Sohn

unread,
Mar 9, 2011, 10:50:05 AM3/9/11
to Repo and Gerrit Discussion
I pushed a patch fixing this to
https://review.source.android.com/#change,21667

--
Matthias

Shawn Pearce

unread,
Mar 9, 2011, 11:50:43 AM3/9/11
to Matthias Sohn, Repo and Gerrit Discussion
On Wed, Mar 9, 2011 at 07:50, Matthias Sohn
<matthi...@googlemail.com> wrote:
> On Mar 9, 2:53 pm, Sasa Zivkov <ziv...@gmail.com> wrote:
>> We found that in Gerrit 2.1.6.1 (which is the latest release) reflog is
>> disabled for all newly created projects.
>> Means: core.logallrefupdates=false
...

>> We will try to provide Gerrit patch for this issue today where we would
>> return to the old behavior
>> by explicitly setting core.logallrefupdates to true after Git repo is
>> initialized.
>
> I pushed a patch fixing this to
> https://review.source.android.com/#change,21667

Thanks, submitted.

I may try to update to JGit master and cut an -rc0 this week. There
are a few useful things queued up, especially some of the recent
performance improvements within JGit.

Matthias Sohn

unread,
Mar 9, 2011, 12:13:18 PM3/9/11
to Shawn Pearce, Repo and Gerrit Discussion
2011/3/9 Shawn Pearce <s...@google.com>

+1, that would be nice

--
Matthias
Reply all
Reply to author
Forward
0 new messages