Code Review scores: 2 * (+1) == +2?

Pat Notz

unread,

Oct 12, 2010, 4:02:59 PM10/12/10

to Repo and Gerrit Discussion

Hi,

Gerrit does something that I find unexpected and a little confusing.
A patch needs a +2 score for acceptance (note: in our installation we
have the Submit feature turned off). When a reviewer gives a patch a
+2 score, I see a check-mark in the "R" column on the change list
pages. However, if a patch as two (or more) +1 review scores, the "R"
column only shows "+1", not a check-mark.

Is that intentional? I thought two +1 scores should be the same as
one +2 score.

Thanks ~ Pat

PS I'm running 2.1.5

Shawn Pearce

unread,

Oct 12, 2010, 4:08:21 PM10/12/10

to Pat Notz, Repo and Gerrit Discussion

Nope. Gerrit doesn't support summing scores yet.

Pat Notz

unread,

Oct 12, 2010, 4:24:06 PM10/12/10

to Shawn Pearce, Repo and Gerrit Discussion

Ah, okay... but it *does* sum them when deciding whether to show the
Submit button, right?

Jay Soffian

unread,

Oct 12, 2010, 4:36:06 PM10/12/10

to Pat Notz, Shawn Pearce, Repo and Gerrit Discussion

On Tue, Oct 12, 2010 at 4:24 PM, Pat Notz <pat...@gmail.com> wrote:
> Ah, okay... but it *does* sum them when deciding whether to show the
> Submit button, right?

Nope. See http://gerrit.googlecode.com/svn/documentation/2.1.5/access-control.html#category_CVRW

Basically, in the default config it must have a +2 and no -2.
Basically +/-1 are advisory only.

j.

Pat Notz

unread,

Oct 12, 2010, 4:45:14 PM10/12/10

to Jay Soffian, Shawn Pearce, Repo and Gerrit Discussion

Ah, okay. Thanks!

Reply all

Reply to author

Forward