bug when running make in a completely fresh clone of repository, and markdown doesn't exist

[asoko...@gmail.com]

Hi everyone, I think this is broken.  I don't have markdown, but it looks like the build process is designed to generate a skeleton md-to-man containing "echo Skipping: $2.1 >&2".  However, it seems like this is not generated, so the build fails at a later step.

To reproduce, clone a completely fresh copy of mildred's version of the repository (https://github.com/mildred/redo.git) in an environment where the markdown python library is not installed, and just run make.  The bug exists as of revision 5053e12392a95d961578d03ae2809fd383d7208b.

$ make
./redo all
redo  all
redo    _all
redo      version/gitvars
redo      Documentation/all
redo        Documentation/md-file-list
redo        Documentation/redo-always.1
redo          Documentation/md-to-man
Traceback (most recent call last):
echo Skipping: $2.1 >&2
  File "./md2man.py", line 2, in <module>
    import sys, os, markdown, re
ImportError: No module named markdown
Warning: md2man.py missing modules; can't generate manpages.
redo          Documentation/redo-always.md.tmp
Warning: try this: sudo easy_install markdown BeautifulSoup
default.1.do: line 2: ./md-to-man: No such file or directory
redo        Documentation/redo-always.1: exit code 1
redo      Documentation/all: exit code 123
redo    _all: exit code 1
redo  all: exit code 1
make: *** [all] Error 1

Cheers,
Aaron

[Mildred Ki'Lya]

On 2013-01-28 10:58, asoko...@gmail.com wrote:
> Hi everyone, I think this is broken. I don't have markdown, but it
> looks like the build process is designed to generate a skeleton
> md-to-man containing "echo Skipping: $2.1 >&2". However, it seems
> like this is not generated, so the build fails at a later step.
>
> To reproduce, clone a completely fresh copy of mildred's version of
> the repository (https://github.com/mildred/redo.git) in an environment
> where the markdown python library is not installed, and just run
> make. The bug exists as of revision
> 5053e12392a95d961578d03ae2809fd383d7208b.

This is now fixed in the last commit.

The problem was that md-to-man didn't sent its output to $3 in my
branch, now that I disabled stdout-as-result mode.

[Aaron Sokoloski]

Ah, fantastic.  I was running on an old version prior to this, and wasn't aware of the stdout-as-result change you mention, otherwise I probably would have spotted that myself.  I'll have to make sure I'm not relying on writing to stdout.  Seems like a smart change.

Thanks so much,
Aaron