2.6.0 Makefile bug?

[Charlie Orford]

Hi List

The README for 2.6.0. mentions one can change the default install directory by passing PREFIX=/custom/path  However, it seems the Makefile (line 84) appends "bin" to this.

I was trying to install to /usr/local/sbin and spent a few minutes scratching my head before I realised the installer had placed everything in /usr/local/sbin/bin :)

I guess either the Makefile needs changing or the instructions in the README file need updating to indicate "/bin" is appended to PREFIX.

Cheers
Charlie

P.S. I'm not 100% sure but I don't remember encountering this problem with 2.6.0-rc5

[Salvatore Sanfilippo]

Hey Charlie,

why is this a problem? It is common for PREFIX to be the "radix" and
append to it /etc, /bin, and so forth.

Also Redis is not a privileged executable, does not require any root
privilege to run, and by default binds to a port > 1024, so /sbin is
not its natural target IMHO.

Cheers,
Salvatore

> --
> You received this message because you are subscribed to the Google Groups
> "Redis DB" group.
> To post to this group, send email to redi...@googlegroups.com.
> To unsubscribe from this group, send email to
> redis-db+u...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/redis-db?hl=en.



--
Salvatore 'antirez' Sanfilippo
open source developer - VMware
http://invece.org

Beauty is more important in computing than anywhere else in technology
because software is so complicated. Beauty is the ultimate defence
against complexity.
— David Gelernter

[Charlie Orford]

Hi Salvatore,

Sorry about that post, I wasn't having a very good day :) I think
you're right. It isn't a problem and is pretty standard behaviour.

I guess I was just expecting the Makefile to dump the files in PREFIX
because the install process is so lightweight and minimal (i.e. no libs,
man files, conf files etc. just a handful of binaries).

As for putting redis in /usr/local/sbin, again you're right and there is
no intrinsic reason it should be there. Our nginx and uwsgi binaries
live in /usr/local/sbin and it just felt natural to put redis in the
same place.

All the best,
Charlie