Esent issue on WinXP

[Tobi]

The first time I've upgraded a customer to the latest stable release of
RavenDB and it crashes :-(

Here's the log:

http://pastie.org/3602347

This only happens on WinXP/32bit. The same operations on the same data
work fine on Win7/64bit. Maybe it is related to the Esent version?

Tobias

[Tobi]

Am 15.03.2012 18:29, schrieb Tobi:

> http://pastie.org/3602347
>
> This only happens on WinXP/32bit. The same operations on the same data
> work fine on Win7/64bit. Maybe it is related to the Esent version?

PS: This is what the application is doing at this point:

var docs = DocumentDatabase.GetDocumentsWithIdStartingWith("Sales",
skip, 1024);

Tobias

[Tobi]

PPS: And a tiny program to reproduce the crash:

http://pastie.org/3602810

Works on Win7, but crashes on WinXP.

Tobias

[Oren Eini (Ayende Rahien)]

Okay, that is interesting.

Can you check what the value of SystemParameters.BookmarkMost is?

I don't have an XP machine handy, would it be possible to do a skype session to resolve this?

[Tobi]

On 15.03.2012 20:17, Oren Eini (Ayende Rahien) wrote:

> Can you check what the value of SystemParameters.BookmarkMost is?

It's 256.

At this line:

https://github.com/ayende/ravendb/blob/master/Raven.Storage.Esent/StorageActions/OptimizedIndexReader.cs#L72

I see, that bookmark.Length is 0. Didn't had a chance yet to do any
further debugging.

> I don't have an XP machine handy, would it be possible to do a skype
> session to resolve this?

Tomorrow, when I'm back at work. I'm already at home and only have remote
access to my development and the XP machine.

Tobias

[Oren Eini (Ayende Rahien)]

I can't see how this can happen.

JetGetSecondaryIndexBookmark is there to set things up, and I can't see it returning zero there.

I check , and it is supported on win XP

[Tobi]

On 15.03.2012 21:20, Oren Eini (Ayende Rahien) wrote:

> I can't see how this can happen.
> JetGetSecondaryIndexBookmark is there to set things up, and I can't see it
> returning zero there.
> I check , and it is supported on win XP

"actualBookmarkSize" (=primary key bookmark buffer size) returned by
JetGetSecondaryIndexBookmark is 0 while "ignored" (=secondary key buffer
size) isn't.

...but I can't explain this either.

Tobias

[Oren Eini (Ayende Rahien)]

I guess it is possible that on XP, if the first buffer isn't big enough, it won't update the second buffer?

[Tobi]

On 16.03.2012 07:23, Oren Eini (Ayende Rahien) wrote:

> I guess it is possible that on XP, if the first buffer isn't big enough,
> it won't update the second buffer?

But why should the first buffer be too small?

On Win7 the buffer sizes are 1001 and on WinXP they are 256.

On Win7 AND WinXP I see the actual size of the secondary key never beeing
larger than 26. But the size of the primary key always is returned with 0
on WinXP (and 5 on Win7).

Tobias

[Oren Eini (Ayende Rahien)]

What is we would pass a null to the first buffer?

[Tobi]

On 16.03.2012 08:36, Oren Eini (Ayende Rahien) wrote:

> What is we would pass a null to the first buffer?

Passing null, 0 for the secondary key buffer causes a "Buffer too small"
exception as expected.

I'll do some debugging at the Managed Esent as soon as I'm back in the
office to see what the actual return value of JetGetSecondaryIndexBookmark is.

You have more insight into the Esent-interface. How should a tiny test
program look like that just opens the Esent DB and runs
JetGetSecondaryIndexBookmark?

Tobias

[Oren Eini (Ayende Rahien)]

I attached a minimal program that uses this.

[Tobi]

On 16.03.2012 09:09, Oren Eini (Ayende Rahien) wrote:

> I attached a minimal program that uses this.

...small bug in format string, but it works just fine:

Pri 4 Sec 16

Tobias

[Tobi]

On 16.03.2012 10:36, Tobi wrote:

I've enabled a trace log for Managed Esent:

Win7: http://pastie.org/3607189
WinXP: http://pastie.org/3607194

Tobias

[Tobi]

PS: This was for opening an existing DB and doing a single
GetDocumentsWithIdStartingWith() call.

Tobias

[Oren Eini (Ayende Rahien)]

What happen if you continue to do iterations on the data? Api.TryMoveNext() ?

[Tobi]

On 16.03.2012 11:37, Oren Eini (Ayende Rahien) wrote:

> What happen if you continue to do iterations on the data? Api.TryMoveNext() ?

Same return values:

Pri 4 Sec 16
Pri 4 Sec 16
Pri 4 Sec 16
Pri 4 Sec 16
...

Tobias

[Tobi]

I'm running out if ideas.

I tried to reproduce every single Esent-API-call from
GetDocumentsWithIdStartingWith(), but I fail to reproduce this problem in
isolation.

But on WinXP GetDocumentsWithIdStartingWith() fails consistently.

Tobias

[Oren Eini (Ayende Rahien)]

Okay, I'll take a look on Sunday.

[Tobi]

On 16.03.2012 13:25, Oren Eini (Ayende Rahien) wrote:

> Okay, I'll take a look on Sunday.

Ok.

To add some extra weirdness to the problem:

Map/reduce, which uses the OptimizedIndexReader as well, works fine on
WinXP and the actualBookmarkSize returned by JetGetSecondaryIndexBookmark
is > 0.

Tobias

[Tobi]

Digging a bit deeper into this:

JetGetSecondaryIndexBookmark is called for the "by_key" index which is
primary. May this be the issue?

Tobias

[Tobi]

On 16.03.2012 13:57, Tobi wrote:

> Map/reduce, which uses the OptimizedIndexReader as well, works fine on
> WinXP and the actualBookmarkSize returned by JetGetSecondaryIndexBookmark
> is > 0.

...my fault - wrong line. It's not primary.

Tobias

[Tobi]

Ha! Got it!

Modify your esent-only test program to create the index with:

CreateIndexGrbit.IndexDisallowNull | CreateIndexGrbit.IndexUnique

instead of just CreateIndexGrbit.IndexDisallowNull.

In this case, it fails on WinXP and prints:

Pri 0 Sec 20

But why?

Tobias

[Tobi]

http://managedesent.codeplex.com/discussions/348886

Tobias

[Matt Warren]

I know next to nothing about Esent, so I was just using the sample code posted above to play around and learn a bit.

But as I was reading the code sample here, I noticed this comment

// Be careful with ColumndefGrbit.ColumnNotNULL. Older versions of ESENT
// (e.g. Windows XP) do not support this grbit for tagged or variable columns
// (JET_coltyp.Text, JET_coltyp.LongText, JET_coltyp.Binary, JET_coltyp.LongBinary)

Don't know if this helps or not?

[Oren Eini (Ayende Rahien)]

Okay, that answer gives us the solution, I'll move to Api.JetGetBookmark, instead.

On Fri, Mar 16, 2012 at 11:03 PM, Tobi <lista...@e-tobi.net> wrote:

http://managedesent.codeplex.com/discussions/348886

Tobias

[Tobi]

On 18.03.2012 11:49, Oren Eini (Ayende Rahien) wrote:

> Okay, that answer gives us the solution, I'll move to Api.JetGetBookmark,
> instead.

I've cherry-picked this into stable and tested it - works fine!

Thanks!

BTW: Any plans for a new stable?

Tobias

[Oren Eini (Ayende Rahien)]

Soon

[Justin A]

On Monday, 19 March 2012 23:20:17 UTC+11, Oren Eini wrote:

Soon