Suggestion for shadow Puppet

[dreamcat4]

Hi,
Here is a small improvement for Shadow Puppet Manifests class.

http://github.com/dreamcat4/shadow_puppet/commit/326d0739f111d9411443f713e29f73cb5ffd1357


Best regards,

dreamcat4
drea...@gmail.com

[Jesse Newland]

Looks good! Do you have an example of how you're using this?

Regards -

Jesse Newland
---
je...@railsmachine.com
404.216.1093

[dreamcat four]

No, not myself.

However it would be fairly harmless to provide this convenience
method. There is already a very similar method just a little further
down in the same file. See:
http://github.com/dreamcat4/shadow_puppet/blob/326d0739f111d9411443f713e29f73cb5ffd1357/lib/shadow_puppet/manifest.rb#L192

An example usage would be to clean up the moonshine recipies.rb file.
Where it says:

def apache_stack
self.class.recipe :apache_server
self.class.recipe :passenger_gem, :passenger_configure_gem_path,
:passenger_apache_module, :passenger_site
self.class.recipe ...

Its not usually necessary to specify which class. So it would look like this;

def apache_stack
recipe :apache_server
recipe :passenger_gem, :passenger_configure_gem_path,
:passenger_apache_module, :passenger_site
recipe ...

Ahh


Best regards

dreamcat4
drea...@gmail.com

[dreamcat4]

Hi again,

Actually theres other ShadowPuppet change(s) coming. So it makes more
sense to hold back until then at least.


Best regards,

dreamcat4
drea...@gmail.com

On Oct 22, 3:20 pm, dreamcat4 <dreamc...@gmail.com> wrote:
> Hi,
> Here is a small improvement for Shadow Puppet Manifests class.
>

> http://github.com/dreamcat4/shadow_puppet/commit/326d0739f111d9411443...
>
> Best regards,
>
> dreamcat4
> dreamc...@gmail.com