Add option for specifying total row count to add_limit_offset!

1 view
Skip to first unread message

Erik Bryn

unread,
Dec 10, 2009, 6:02:54 PM12/10/09
to Rails SQLServer Adapter
It'd be great if we could bypass the automatic row counting performed
in #add_limit_offset! by specifying a count ourselves somehow.

If you're using will_paginate, the total row counts are being
performed twice - once by will_paginate and then once again by the
adapter in #add_limit_offset!.

Anybody else run across this?

- Erik

Ken Collins

unread,
Dec 10, 2009, 11:17:01 PM12/10/09
to rails-sqlse...@googlegroups.com

Yea, I saw this too. I did not pay close enough attention to see if it was the same SQL and hence cached for that particular request. I'd gladly take a look at a patch, but that #add_limit_offset! will certainly die soon I'm sure too. Well, for the 2005/2008 version optimizations and when I get off my but and start testing AR3 and the new AREL stuff.

- Ken
> --
>
> You received this message because you are subscribed to the Google Groups "Rails SQLServer Adapter" group.
> To post to this group, send email to rails-sqlse...@googlegroups.com.
> To unsubscribe from this group, send email to rails-sqlserver-a...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/rails-sqlserver-adapter?hl=en.
>
>

Reply all
Reply to author
Forward
0 new messages