Awesome work. One element of concern - John had specifically used regex matching in the RuledTable and SiteMap on the class attributes because it was faster than add/remove/has_classname in Prototype. Has that issue been resolved?
John and I also mused at re-implementing some of the Javascript as LowPro Behaviors. Would you be interested in contributing to that effort?
On 10/20/07, Sean Cribbs <seancri...@gmail.com> wrote:
> Awesome work. One element of concern - John had specifically used regex > matching in the RuledTable and SiteMap on the class attributes because it > was faster than add/remove/has_classname in Prototype. Has that issue been > resolved?
Yes, that was the reason I reverted to add/removeClassName.
John and I also mused at re-implementing some of the Javascript as LowPro
> Behaviors. Would you be interested in contributing to that effort?
Behaviors are nice, but not needed in Radiant administrative interface. SiteMap currently applies event handlers to each row of the table, which is unnecessary because only one click handler on the whole table is enough. I have not implemented that, though, because with this patch I tried to stay as close to old code as possible. However, I will do that once this initial patch is applied, gladly.
Behaviors might be used in TabControl, but I don't think this tiny usage justifies the inclusion of the whole Prototype add-on.
On 10/20/07, Sean Cribbs <seancri...@gmail.com> wrote:
> Mislav,
> Awesome work.
Sean,
Will this be committed soon? I'd like to make a second patch with a complete cleanup, if you and John agree. Obscure scripts in views bit me already a few times while extending the interface; I'd like to extract to external files and sanitize those.
> Will this be committed soon? I'd like to make a second patch with a > complete cleanup, if you and John agree. Obscure scripts in views bit > me already a few times while extending the interface; I'd like to > extract to external files and sanitize those.
I think a general cleanup would be good, perhaps with some modularization. The whole interface and controller structure is due for a redesign of sorts; however, that probably won't happen until after 0.6.5. These are not complete and some will have greater priorities than others, but here's my wishlist for the front-end:
* Resourceful, skinny controllers (AR-compatible, too!) * Better modularization of the Javascripts, fewer intrusions into the markup * Simpler markup structure in some places (the page-edit screen comes to mind)
> Will this be committed soon? I'd like to make a second patch with a > complete cleanup, if you and John agree. Obscure scripts in views bit > me already a few times while extending the interface; I'd like to > extract to external files and sanitize those.
I think a general cleanup would be good, perhaps with some modularization.
> The whole interface and controller structure is due for a redesign of sorts; > however, that probably won't happen until after 0.6.5. These are not > complete and some will have greater priorities than others, but here's my > wishlist for the front-end:
> * Resourceful, skinny controllers (AR-compatible, too!) > * Better modularization of the Javascripts, fewer intrusions into the > markup > * Simpler markup structure in some places (the page-edit screen comes to > mind)
I agree. Cleaning away JavaScript is a good first step towards all this. Pistonizing Rails 2.0 in vendor/ is another ;)
I guess I'll be done with what I planned today or tomorrow. I'm going to post patches with Pastie here - Radiant Trac is hard to look with this unfinished light -> dark transition ..
Fixing the edit view was harder than I thought. To be honest, it was a nightmare, and even after this patch there is still little inline JavaScript that I might remove in the next iteration.
- (almost) completely rewritten RuledTable, SiteMap and TabControl - upgraded Prototype to latest trunk - added admin.js that contains unobtrusive hooks - cleaned up index and edit views from inline javascript that did initialization - selected content part tab while editing a page is persisted between page views - title field no longer receives autofocus on page load (that annoyed me a lot)
Mislav Marohnic' wrote: > Fixing the edit view was harder than I thought. To be honest, it was a > nightmare, and even after this patch there is still little inline > JavaScript that I might remove in the next iteration.
> * (almost) completely rewritten RuledTable, SiteMap and TabControl > * upgraded Prototype to latest trunk > * added admin.js that contains unobtrusive hooks > * cleaned up index and edit views from inline javascript that did > initialization > * selected content part tab while editing a page is persisted > between page views > * title field no longer receives autofocus on page load (that > annoyed me a lot)
Mislav Marohnic' wrote: > Fixing the edit view was harder than I thought. To be honest, it was a > nightmare, and even after this patch there is still little inline > JavaScript that I might remove in the next iteration.
> * (almost) completely rewritten RuledTable, SiteMap and TabControl > * upgraded Prototype to latest trunk > * added admin.js that contains unobtrusive hooks > * cleaned up index and edit views from inline javascript that did > initialization > * selected content part tab while editing a page is persisted > between page views > * title field no longer receives autofocus on page load (that > annoyed me a lot)
