BUG: cookies with expiration date

0 views
Skip to first unread message

Ivan Ukhov

unread,
Oct 29, 2009, 4:15:46 PM10/29/09
to Rack Development
Hi!

Please have a look at this line:

http://github.com/rack/rack/blob/663abfce9b71ab273c8adc0e76c233671bc43e1d/lib/rack/response.rb#L64

value[:expires].clone.gmtime.strftime("%a, %d-%b-%Y %H:%M:%S GMT")

My default system locale is ru_RU.UTF8, therefore this line produces
string with Russian letters. Browsers cant set expiration date in
Russian. FF sets session cookies, Safari doesnt set cookies at all.
Suppose this is a bug. Instead of strftime, rfc2822 should be used.

Thanks.
Reply all
Reply to author
Forward
0 new messages