building on linux

[schnitzel]

I just grabbed the latest with hg and have just a couple of minor
things to report:

1) in qextserialenumerator.cpp: move includes for objbase.h and
initguid.h inside the win ifdef
2) in qextserialport.cpp: inside constructor, setTimeout should only
take one argument settings.Timeout_Millisec.
3) scanPortsNix signature should be:
void QextSerialEnumerator::scanPortsNix(QList<QextPortInfo> &
infoList)
4) bottom of scanPortsNix change "ports << inf" to "infoList << inf"
5) top of qextserialenumerator.h: after QObject include, add
QStringList and QDir includes

hth

[Liam Staskawicz]

Thanks for the report - comments inline...

Liam

On Feb 1, 2010, at 1:09 PM, schnitzel wrote:

> I just grabbed the latest with hg and have just a couple of minor
> things to report:
>
> 1) in qextserialenumerator.cpp: move includes for objbase.h and
> initguid.h inside the win ifdef

This is already inside the #ifdef Q_OS_WIN. Maybe you're looking at an older version? http://code.google.com/p/qextserialport/source/browse/src/qextserialenumerator.cpp#30 looks good.

> 2) in qextserialport.cpp: inside constructor, setTimeout should only
> take one argument settings.Timeout_Millisec.

Not sure what you mean here. setTimeout() only takes one param

> 3) scanPortsNix signature should be:
> void QextSerialEnumerator::scanPortsNix(QList<QextPortInfo> &
> infoList)

This is the signature.

> 4) bottom of scanPortsNix change "ports << inf" to "infoList << inf"

Updated.

> 5) top of qextserialenumerator.h: after QObject include, add
> QStringList and QDir includes

Put these in qextserialenumerator.cpp

>
> hth
>
> --
> You received this message because you are subscribed to the Google Groups "qextserialport" group.
> To post to this group, send email to qextser...@googlegroups.com.
> To unsubscribe from this group, send email to qextserialpor...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/qextserialport?hl=en.
>