> I have been using tornado for nearly 2 years!  Now, I begin to read the
> resource code, and find some code can be more beautiful. show  a instance
>  as follows:

> In the page “
> https://github.com/jaixiaolei/tornado/blob/master/tornado/database.py”，we
> can find the code:

> def close(self):
>         """Closes this database connection."""
>         if getattr(self, "_db", None) is not None:
>             self._db.close()
>             self._db = None

> in my views,  if getattr(self, "_db", None) is not None: can be replaced
> to if hasattr(self,"_db"):

> def close(self):
>         """Closes this database connection."""
>         if hasattr(self, "_db"):
>             self._db.close()
>             self._db = None

> Is someone agree me?

> #NOTE: first time give an advice to tornado. maybe in the following days,
> i will send more thinking about tornado.

> -- Jia Xiaolei

> --
> blog: http://chenxiaoyu.org

> 2012/1/10 贾晓磊 <jiaxiaolei19871...@gmail.com>

>> hi, all

>> I have been using tornado for nearly 2 years!  Now, I begin to read the
>> resource code, and find some code can be more beautiful. show  a instance
>>  as follows:

>> In the page “
>> https://github.com/jaixiaolei/tornado/blob/master/tornado/database.py”，we
>> can find the code:

>> def close(self):

>>         """Closes this database connection."""

>>         if getattr(self, "_db", None) is not None:

>>             self._db.close()

>>             self._db = None

>> in my views,  if getattr(self, "_db", None) is not None: can be replaced
>> to if hasattr(self,"_db"):

>> def close(self):

>>         """Closes this database connection."""

>>         if hasattr(self, "_db"):

>>             self._db.close()

>>             self._db = None

>> Is someone agree me?

>> #NOTE: first time give an advice to tornado. maybe in the following days,
>> i will send more thinking about tornado.

>> -- Jia Xiaolei

> 2012/1/10 smallfish <smallfish...@gmail.com>

>> yes, i think so. perhaps enhance readability

> hehe, thanks for your response.
> I read your blog in "http://chenxiaoyu.org". Good easy!  nginx+tornado
> are also be used in our projject and they work perfect.
> an extra question: how to give advices or bugs to the maintainer of
> tornado. it seems terrible to use  "
> http://www.apache.org/licenses/LICENSE-2.0".

> Nice to meet you!

> -- Jia Xiaolei

>> --
>> blog: http://chenxiaoyu.org

>> 2012/1/10 贾晓磊 <jiaxiaolei19871...@gmail.com>

>>> hi, all

>>> I have been using tornado for nearly 2 years!  Now, I begin to read the
>>> resource code, and find some code can be more beautiful. show  a instance
>>>  as follows:

>>> In the page “
>>> https://github.com/jaixiaolei/tornado/blob/master/tornado/database.py”，we
>>> can find the code:

>>> def close(self):

>>>         """Closes this database connection."""

>>>         if getattr(self, "_db", None) is not None:

>>>             self._db.close()

>>>             self._db = None

>>> in my views,  if getattr(self, "_db", None) is not None: can be
>>> replaced to if hasattr(self,"_db"):

>>> def close(self):

>>>         """Closes this database connection."""

>>>         if hasattr(self, "_db"):

>>>             self._db.close()

>>>             self._db = None

>>> Is someone agree me?

>>> #NOTE: first time give an advice to tornado. maybe in the following
>>> days, i will send more thinking about tornado.

>>> -- Jia Xiaolei

> --
> NAME: 贾晓磊/Jia Xiaolei
> MOBILE: 13011292217
> QQ: 281304051
> MICRO-BLOG:  http://weibo.com/2183890715
> GMAIL: jiaxiaolei19871...@gmail.com <gmail%3Ajiaxiaolei19871...@gmail.com>

> in my views,  if getattr(self, "_db", None) is not None: can be
> replaced to if hasattr(self,"_db"):

> > in my views,  if getattr(self, "_db", None) is not None: can be
> > replaced to if hasattr(self,"_db"):

> Actually that's not the same test at all.  hasattr(self, "_db") will be
> True even if self._db == None.

> >>> class Foo (object):
> ...     def __init__ (self):
> ...         self.bar = None
> ...
> >>> f = Foo ()
> >>> hasattr (f, "bar")
> True

> Therefore you must have getattr (self, "_db") == None.  Except perhaps
> there is no attribute _db, which will throw an exception, so you must
> have a default:

> if getattr(self, "_db", None) is not None

> And now you are back to the original code.

> Regards,
> Cliff