HTTPConnection::_on_headers seems to leak connection

[Jefim]

Hi,

The function HTTPConnection::_on_headers seems to leak connection if
exception is thrown.
This can lead to denial of service on the server.

[David P. Novakovic]

Do you refer to the circular dependency between connection and request?

i'm fairly sure python can detect that these objects have reference to
them or not... no references is kept to the connection object... so if
the request object goes out of scope both of them will be garbage
collected..

I could be wrong though :)

D

[Jefim]

This does not mean memory leak, but the connection leak - the
connection is not closed

On May 24, 1:58 pm, "David P. Novakovic" <davidnovako...@gmail.com>
wrote:

[Jefim]

This does not mean memory leak, but the connection leak - the
connection is not closed

On May 24, 1:58 pm, "David P. Novakovic" <davidnovako...@gmail.com>
wrote:

[David P. Novakovic]

Python sockets are closed when they are garbage collected - ie. when
they go out of scope.

[Jefim]

This does not mean memory leak, but the connection leak - the
connection is not closed

On May 24, 1:58 pm, "David P. Novakovic" <davidnovako...@gmail.com>
wrote:

[Jefim]

This does not mean memory leak, but the connection leak - the
connection is not closed

On May 24, 1:58 pm, "David P. Novakovic" <davidnovako...@gmail.com>
wrote: