pyvorbis-1.5 pre-release

Eric Faurot

unread,

Oct 24, 2006, 3:53:29 PM10/24/06

to py...@googlegroups.com

Hi all,

I have integrated the patch by Greg Ward into pyvorbis-1.4 for a
pyvorbis-1.5 bugfix release. I have put a tarball there:
http://ekyo.nerim.net/software/pyogg/pyvorbis-1.5a.tar.gz

Please tell me if it works ok. If so, I'll release 1.5 very soon.

Eric.

Greg Ward

unread,

Oct 24, 2006, 10:12:55 PM10/24/06

to PyOgg

Eric Faurot wrote:
> I have integrated the patch by Greg Ward into pyvorbis-1.4 for a
> pyvorbis-1.5 bugfix release. I have put a tarball there:
> http://ekyo.nerim.net/software/pyogg/pyvorbis-1.5a.tar.gz

One slight little problem: you didn't actually apply my patch!

$ md5sum pyvorbis-1.4/src/vorbismodule.c
pyvorbis-1.5a/src/vorbismodule.c
92c17f76e289a951a3efbd84b9807c4d pyvorbis-1.4/src/vorbismodule.c
92c17f76e289a951a3efbd84b9807c4d pyvorbis-1.5a/src/vorbismodule.c

Also, if the only change here is my bugfix, shouldn't this just be
pyvorbis-1.4.1? Calling it 1.5 generally implies new features.

Greg

Eric Faurot

unread,

Oct 25, 2006, 3:48:30 AM10/25/06

to py...@googlegroups.com

On 10/25/06, Greg Ward <gerg...@gmail.com> wrote:
>
> Eric Faurot wrote:
> > I have integrated the patch by Greg Ward into pyvorbis-1.4 for a
> > pyvorbis-1.5 bugfix release. I have put a tarball there:
> > http://ekyo.nerim.net/software/pyogg/pyvorbis-1.5a.tar.gz
>
> One slight little problem: you didn't actually apply my patch!

I think the file in question is actually pyvorbisfile.c

> Also, if the only change here is my bugfix, shouldn't this just be
> pyvorbis-1.4.1? Calling it 1.5 generally implies new features.

It can be 1.4.1, as far as I am concerned. I was just following the
same <major>.<minor> versioning scheme.

Eric.

Greg Ward

unread,

Oct 28, 2006, 4:34:51 PM10/28/06

to PyOgg

[me]

> One slight little problem: you didn't actually apply my patch!

[Eric Faurot]

> I think the file in question is actually pyvorbisfile.c

Oops, you're right. But I'm also right: those two files are identical
between 1.4 and your test 1.5a release. "diff -ru" reveals that the
only changes are to:

ChangeLog
PKG-INFO
setup.py

Greg

Eric Faurot

unread,

Nov 6, 2006, 3:04:42 AM11/6/06

to py...@googlegroups.com

On 10/28/06, Greg Ward <gerg...@gmail.com> wrote:

> Oops, you're right. But I'm also right: those two files are identical
> between 1.4 and your test 1.5a release. "diff -ru" reveals that the
> only changes are to:
>
> ChangeLog
> PKG-INFO
> setup.py