Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
pyjaco - The Python to Javascript compiler
Home
+ new post
About this group
Join this group
Message from discussion failing tests on windows
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Samuel Ytterbrink  
View profile  
 More options Feb 17 2012, 1:55 am
From: Samuel Ytterbrink <nepp...@gmail.com>
Date: Fri, 17 Feb 2012 07:55:14 +0100
Local: Fri, Feb 17 2012 1:55 am
Subject: Re: [pyjaco] Re: failing tests on windows
Print | View thread | Show original | Report this message | Find messages by this author
I have now read and confirmed this patch, up to rev f45da41947ae!

I dont remember about the [] more then that it was importent in some
other code. Its to bad that the comment of the revision you change it
dont state why, only that you remove them.

Could be good fore future reference if we find that it breaks, maybe on mac?

how ever i remember that on the other place we used the brackets we
had a check for the operating system.

I'll merge this soon, if i dont hear anything else from chrivers.

at least 2+ for good coding style!

2012/2/16 g <wgordo...@gmail.com>:

> So I made a minor tweak to the test running code and now the tests
> pass for me on Windows.  Revision 498aa55d7a7a of my repo at
> https://bitbucket.org/pendletongp/pyjaco/

> I set up an Ubuntu virtual box to make sure that the tests still
> passed on Linux.  Seemed to be okay.  Would anyone mind confirming?  A
> few failed, but they failed in the official repo too.  It just seems
> like wrapping the cmd argument to subprocess.call in a list was
> causing Windows to wrap the entire command in quotes causing
> everything to fail.

> I also made it so that the environment test used the same call code as
> the rest of the tests.  I think it might be a good idea to add a test
> to env_test that checks to make sure the javascript load command is
> available.  Ubuntu told me to install nodejs to get the js command...
> but node doesn't provide the "load" command like the d8 shell does.

> --
> You are subscribed to the Google Group pyjaco@googlegroups.com
> To unsubscribe from this group, send email to
> pyjaco+unsubscribe@googlegroups.com

--
//Samuel Ytterbrink

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google