pymsnt getAvatarData stopped working?

[mc]

Hi,

it seems to me that getting avatar images from MSN stopped working.
When I change the image in WLM2009 (to something that is not in the
cache :-)) nothing happens in my Jabber client(s). Here is the log:

[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: ::
contactAvatarChanged :: msn.msnw.NotificationClient :: {'self':
'instance', 'hash': '43a89e9f29f370efeb4337792d1c2f9859131b9d',
'userHandle': 'm...@hotmail.com'}
[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: ::
contactAvatarChanged :: glue.LegacyConnection :: {'self': 'instance',
'hash': '43a89e9f29f370efeb4337792d1c2f9859131b9d', 'userHandle':
'm...@hotmail.com'}
[2009-05-04 18:32:03] INFO :: :: Avatar not found. ::
getAvatarData :: AvatarCache :: {'self': 'instance', 'key':
'43a89e9f29f370efeb4337792d1c2f9859131b9d', 'filename': '/tmp/avatars/
43a/43a89e9f29f370efeb4337792d1c2f9859131b9d'}
[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: ::
sendAvatarRequest :: glue.LegacyConnection :: {'self': 'instance',
'userHandle': 'm...@hotmail.com'}
[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: ::
contactStatusChanged :: msn.msnw.NotificationClient :: {'self':
'instance', 'screenName': 'MSN im MSN 2', 'userHandle':
'm...@hotmail.com', 'statusCode': 'NLN'}
[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: ::
contactStatusChanged :: glue.LegacyConnection :: {'remoteUser':
'm...@hotmail.com', 'self': 'instance'}
[2009-05-04 18:32:03] INFO :: m...@jabber.tld :: :: sendPresence ::
Session :: {'status': u'howdy!', 'show': None, 'self': 'instance',
'fro': 'me%hotma...@msn.jabber.tld/msn', 'avatarHash': '', 'ptype':
None, 'priority': None, 'to': u'm...@jabber.tld', 'nickname': u'MSN im
MSN 2', 'payload': [<twisted.words.xish.domish.Element object at
0x1d74ad0>]}
[2009-05-04 18:32:13] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:13] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:32:14] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x1d78e18>
field5,16777248
[2009-05-04 18:37:47] INFO :: (u'm...@jabber.tld',
'm...@hotmail.com') :: :: connectionLost ::
msn.msnw.OneSwitchboardSession :: {'reason':
<twisted.python.failure.Failure <class
'twisted.internet.error.ConnectionLost'>>, 'self': 'instance'}
[2009-05-04 18:37:47] Stopping factory
<twisted.internet.protocol.ClientFactory instance at 0x1d70cb0>

so sendAvatarRequest() is being called but never arrives at
updateAvatarCB(), so it seems to get stuck somewhere in the SLP
transfer. Anybody else seeing this? Any hints appreciated.

best,
mc

[mc]

More evidence with MSNP2PDebug=True:

[2009-05-05 11:23:40] Unpacked fields: 0x202ee08d 0x5ef3d4 0x33a6
0x39df 0x4b2 0x1000020 0x1b23d77 0x0 0x0 0x1
[2009-05-05 11:23:40] wait_data
[2009-05-05 11:23:40] Unpacked fields: 0x202ee08d 0x5ef3d4 0x33a6
0x39df 0x4b2 0x1000020 0x1b23d77 0x0 0x0 0x1
[2009-05-05 11:23:40] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x25824d0>
field5,16777248
[2009-05-05 11:23:40] >> MSG m...@hotmail.com MSN%20im%20MSN%202 575
[2009-05-05 11:23:40] >> MIME-Version: 1.0
[2009-05-05 11:23:40] >> Content-Type: application/x-msnmsgrp2p
[2009-05-05 11:23:40] >> P2P-Dest: m...@hotmail.de
[2009-05-05 11:23:40] >> P2P-Src: m...@hotmail.com
[2009-05-05 11:23:40] >> [binary data deleted]
[2009-05-05 11:23:40] Unpacked fields: 0x202ee08d 0x5ef3d4 0x3858
0x39df 0x187 0x1000020 0x1b23d77 0x0 0x0 0x1
[2009-05-05 11:23:40] wait_data
[2009-05-05 11:23:40] Unpacked fields: 0x202ee08d 0x5ef3d4 0x3858
0x39df 0x187 0x1000020 0x1b23d77 0x0 0x0 0x1
[2009-05-05 11:23:40] Warning in transfer:
<legacy.msn.msn.SLPLink_AvatarReceive instance at 0x25824d0>
field5,16777248
4d0> field5,16777248
[2009-05-05 11:23:49] >> CHL 0 22666874430394186753
[2009-05-05 11:23:49] << QRY 11 PROD0090YUAUV{2B 32
[2009-05-05 11:23:49] >> QRY 11
[2009-05-05 11:24:10] >> MSG m...@hotmail.com MSN%20im%20MSN%202 184
[2009-05-05 11:24:10] >> MIME-Version: 1.0
[2009-05-05 11:24:10] >> Content-Type: application/x-msnmsgrp2p
[2009-05-05 11:24:10] >> P2P-Dest: m...@hotmail.de
[2009-05-05 11:24:10] >> P2P-Src: m...@hotmail.com
[2009-05-05 11:24:10] >>
[2009-05-05 11:24:10] ��^ ﳲ
[2009-05-05 11:24:10] Unpacked fields: 0x0 0x5ef3d5 0x0 0x0 0x0 0x4
0x1b2b3ef 0x0 0x0 0x0
[2009-05-05 11:24:18] << PNG
[2009-05-05 11:24:18] >> QNG 49
[2009-05-05 11:24:40] >> MSG m...@hotmail.com MSN%20im%20MSN%202 184
[2009-05-05 11:24:40] >> MIME-Version: 1.0
[2009-05-05 11:24:40] >> Content-Type: application/x-msnmsgrp2p
[2009-05-05 11:24:40] >> P2P-Dest: m...@hotmail.de
[2009-05-05 11:24:40] >> P2P-Src: m...@hotmail.com
[2009-05-05 11:24:40] >>
[2009-05-05 11:24:40] ��^ )�
[2009-05-05 11:24:40] Unpacked fields: 0x0 0x5ef3d6 0x0 0x0 0x0 0x4
0x1b3291f 0x0 0x0 0x0
[2009-05-05 11:25:08] << PNG
[2009-05-05 11:25:08] >> QNG 48
[2009-05-05 11:25:40] >> MSG m...@hotmail.com MSN%20im%20MSN%202 184
[2009-05-05 11:25:40] >> MIME-Version: 1.0
[2009-05-05 11:25:40] >> Content-Type: application/x-msnmsgrp2p
[2009-05-05 11:25:40] >> P2P-Dest: m...@hotmail.de
[2009-05-05 11:25:40] >> P2P-Src: m...@hotmail.com
[2009-05-05 11:25:40] >>
[2009-05-05 11:25:40] ��. ��^@��^
[2009-05-05 11:25:40] Unpacked fields: 0x202ee08d 0x5ef3d7 0x0 0x0 0x0
0x40 0x5ef3d4 0x0 0x0 0x0
[2009-05-05 11:25:58] << PNG
[2009-05-05 11:25:58] >> QNG 47
[2009-05-05 11:26:48] << PNG
[2009-05-05 11:26:48] >> QNG 42
[2009-05-05 11:27:38] << PNG
[2009-05-05 11:27:38] >> QNG 50
[2009-05-05 11:28:28] << PNG
[2009-05-05 11:28:28] >> QNG 49
[2009-05-05 11:29:18] << PNG
[2009-05-05 11:29:18] >> QNG 43
[2009-05-05 11:30:08] << PNG
[2009-05-05 11:30:08] >> QNG 48
[2009-05-05 11:30:41] INFO :: (u'm...@jabber.tld',

'm...@hotmail.com') :: :: connectionLost ::
msn.msnw.OneSwitchboardSession :: {'reason':
<twisted.python.failure.Failure <class
'twisted.internet.error.ConnectionLost'>>, 'self': 'instance'}

Seems that the transfer stops at 0x3858 of 0x39df bytes, or the
counting is wrong/has changed.

cheers,
mc

[mc]

ok, this seems to work, not sure whether it breaks something else
though.
feel free to review and commit:

--- msn.py (Revision 38285)
+++ msn.py (Arbeitskopie)
@@ -2624,7 +2624,7 @@
ACK = 0x02
WAIT = 0x04
ERR = 0x08
- DATA = 0x20
+ DATA = 0x1000020 # changed from 0x20 for WLM2009 avatar receive
BYEGOT = 0x40
BYESENT = 0x80
DATAFT = 0x1000030

[Norman Rasmussen]

On Fri, May 8, 2009 at 11:26 AM, mc <mcla...@gmail.com> wrote:
> ok, this seems to work, not sure whether it breaks something else
> though.
> feel free to review and commit:

hopefully it doesn't :-) http://hg.sharesource.org/pymsnt/rev/217

--
- Norman Rasmussen
- Email: nor...@rasmussen.co.za
- Home page: http://norman.rasmussen.co.za/