pyMSNt: Personal messages

[Pedros]

Hi,

When I'm changing presence to one without "status", my friends from
MSN still can see my old personal message. I think the problem is,
because if my personal message is empty, pyMSNt is sending UUX with
empty 'data', and I think it should send <Data><PSM></
PSM><CurrentMedia></CurrentMedia></Data>

my fix: msn.py:1934

def changePersonalMessage(self, personal):
"""
Used to change your personal message.

@param personal: the new screen name

@return: A Deferred, the callback for which will be called
when the server acknowledges the change.
The callback argument will be a tuple of 1 element,
the personal message.
"""

id, d = self._createIDMapping()
data = "<Data><PSM>" + personal + "</PSM><CurrentMedia></
CurrentMedia></Data>"
self.sendLine("UUX %s %s" % (id, len(data)))
self.transport.write(data)
def _cb(r):
self.factory.personal = personal
return (personal,)
return d.addCallback(_cb)


PS: I'm not a python developer (maybe "yet" ;) ), I'm only using MSN
and like to testing and discovering why.... so you must try it first,
because I'm not sure if it's ok.

Best regards,
Pedros

[tharkun]

Hi Pedros,

Current pyMSNt development is continued in the following mercurial
repository:

https://sharesource.org/hg/pymsnt/

Maybe you should post a patch (read: diff -u output and not just the
fixed code) here, so that Norman (and others) can test and apply it to
the repository. You should also try to do the patch against the newest
version from that repos.

[Pedros]

Hi,

I have downloaded the latest version from this site before I did some
changes.
As I said I'm not python developer, and for now I don't have time to
start doing this. I didn't installed jabber server and pyMSNt, so I
don't know it this fix is correct, so I thought that writing here is
better in this case.
Maybe in two or three months I will try to start seriously with
python, install all of these stuff (jabber server, pyMSNt) and develop
project a little bit, but we will see....
For now I have discovered two errors and maybe somebody can test my
fixes and update files for me?

Best regards,
Lukasz