deprecation notice: "Files found in modules without specifying 'modules' in file path"

[Andrew Schulman]

Puppet 0.25.1. I'm getting the following log message:

Nov 20 16:50:01 helium puppetmasterd[32124]: DEPRECATION NOTICE: Files
found in modules without specifying 'modules' in file path will be
deprecated in the next major release. Please fix module 'firehol' when no
0.24.x clients are present

I can't understand what this means. What does it mean, "specifying
'modules' in file path"?

I do have files served from a module-based file share. I.e. I have

/etc/puppet/modules/
firehol/
files/
firehol.conf
manifests/
init.pp

In firehol/manifests/init.pp I have

file { "/etc/firehol/firehol.conf":
source => "puppet:///firehol/firehol.conf"
}

and in fileserver.conf I have

[modules]
allow 127.*
allow 192.168.*

As far as I can determine from the docs, this is what I'm supposed to do.
So what else am I supposed to be doing that I'm not?

Thanks,
Andrew.

[Peter Meier]

> I can't understand what this means. What does it mean, "specifying
> 'modules' in file path"?

> [...]

> file { "/etc/firehol/firehol.conf":
> source => "puppet:///firehol/firehol.conf"
> }

file { "/etc/firehol/firehol.conf":

source => "puppet:///modules/firehol/firehol.conf"
}


but as the notice (it's just a notice) tells you don't do it if there
are still 0.24.x clients around.

cheers pete

[Andrew Schulman]

Thanks. That's correct. It seems that the documentation needs to be updated to
explain this. Andrew.

[James Turnbull]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The wiki is open sand editable all you need to do is sign-up for an
account.

Regards

James Turnbull

- --
Author of:
* Pro Linux System Administration (http://tinyurl.com/linuxadmin)
* Pulling Strings with Puppet (http://tinyurl.com/pupbook)
* Pro Nagios 2.0 (http://tinyurl.com/pronagios)
* Hardening Linux (http://tinyurl.com/hardeninglinux)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSwqSdCFa/lDkFHAyAQKbIQgAoI8D+Sf7tUvEgvXcjsEBEBunfNCQocz4
AVA2Qpy0ijkz0mQKHPIYlckFrkGmleCOEUWKxYwsv5tV+1nBLdjk0Y22kFKCx6eL
gpwpVQVM1E/xzbqZ5o0N6Rb3pZxtj5qArq/MYCAUtSeGkrFAWIGzttHjn6BWKZ0P
nAR3o01s2MCF7qbrNJs6ZJZn/ZHgwh8Cb1kz7YnIE/eN5TiED8fVuZYaliULKNf/
sIH9/Fqovev2NZp7/auIVj4DertHWMR/FAzsSiqFO77/myjwa0in7uNmJWI7qWp6
f0MshP1k1tduSem4Gokh226Q9+YTQxVKq/ntS5GH1w63ec2ac57cnA==
=KLQ7
-----END PGP SIGNATURE-----

[Andrew Dickson]

when behavior in puppet changes, i think the docs would need to be
updated by someone familiar with the changes. is it a good idea to
just assume someone in the community will figure out the new behavior
through experimentation and take it upon themselves to correct the
docs?

-drew

> --
>
> You received this message because you are subscribed to the Google Groups "Puppet Users" group.
> To post to this group, send email to puppet...@googlegroups.com.
> To unsubscribe from this group, send email to puppet-users...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/puppet-users?hl=.
>
>
>

[Andrew Schulman]

> The wiki is open sand editable all you need to do is sign-up for an
> account.

OK.

[James Turnbull]

2009/11/24 Andrew Dickson <dr...@number88.com>:

> when behavior in puppet changes, i think the docs would need to be
> updated by someone familiar with the changes. is it a good idea to
> just assume someone in the community will figure out the new behavior
> through experimentation and take it upon themselves to correct the
> docs?
>

It was documented in the Release Notes and the announcement emails:

http://reductivelabs.com/trac/puppet/wiki/ReleaseNotes#deprecations

Regards

James Turnbull

[Andrew Schulman]

> >>> I can't understand what this means. What does it mean, "specifying
> >>> 'modules' in file path"?
> >>> [...]
> >>> file { "/etc/firehol/firehol.conf":
> >>> source => "puppet:///firehol/firehol.conf"
> >>> }
> >> file { "/etc/firehol/firehol.conf":
> >> source => "puppet:///modules/firehol/firehol.conf"
> >> }
> >>
> >> but as the notice (it's just a notice) tells you don't do it if there
> >> are still 0.24.x clients around.
> >
> > Thanks. That's correct. It seems that the documentation needs to be updated to
> > explain this. Andrew.
>
> The wiki is open sand editable all you need to do is sign-up for an
> account.

Done:
http://reductivelabs.com/trac/puppet/wiki/ModuleOrganisation?action=diff&version=45&old_version=44
. I'd appreciate it if someone would check this to see if I got it right.
Also, do the template paths need to be similarly changed to include a
''modules/'' component? I'm not using any templates yet, so I haven't
tried to check this.

[James Turnbull]

2009/11/25 Andrew Schulman <google-gro...@sneakemail.com>:

Thanks Andrew! Much appreciated and apologies the page slipped
through getting updated - I usually cover most of the "this is
new/changed" stuff but this one didn't get beyond the Release Notes.

Regarding templates - that's a good question and I don't know. :) I
don't think so but I'll check and get back to you (and update the
docs).

I'll take a quick look at your edits too!

Thanks

James Turnbull

[James Turnbull]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Turnbull wrote:
>> http://reductivelabs.com/trac/puppet/wiki/ModuleOrganisation?action=diff&version=45&old_version=44
>> . I'd appreciate it if someone would check this to see if I got it right.
>> Also, do the template paths need to be similarly changed to include a
>> ''modules/'' component? I'm not using any templates yet, so I haven't
>> tried to check this.

Edits look great.

Templates do not need a change in the path - they are a function rather
than file serving directly.

Regards

James Turnbull

- --

Author of:
* Pro Linux System Administration (http://tinyurl.com/linuxadmin)
* Pulling Strings with Puppet (http://tinyurl.com/pupbook)
* Pro Nagios 2.0 (http://tinyurl.com/pronagios)
* Hardening Linux (http://tinyurl.com/hardeninglinux)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJLDGfbAAoJECFa/lDkFHAyAlUIAOG2QbijGR1NCbLMozAlKFAF
Tn/asonem21wLllgY+k9hYp+7H1A11OIhOx47dM5m3HJcD2ibp/GFVYGnpWtd9PA
FVqvY+vAZw2eP2oNj90DaiSwNISn1bpQnRDKjT3Ms4elCiG88I0nQDImR1UfiS3X
k5TwwN/EPTdBoofYBNMdi0MInsGC3hbCGe36jhFnK0y6CuW9DU7MbutDMyTXooeh
90hSlZPTGH5uU5hh3C9IE1/oz+I+86tVyQEIWtOX46V+d82VTOvS1xaNhmGuazvU
bqgQyChaHhAmkmwXzqZeseSP6cTsnsRrwrTLtAPtOXkH8Ra3BPOrFt+nXQ+nwEQ=
=UevU
-----END PGP SIGNATURE-----