External nodes Ignore Missing Classes

[Douglas Garstang]

All,

I just did a super simple test where I used the simple external nodes
script at http://docs.puppetlabs.com/guides/external_nodes.html.

I ran it against an existing node (which you have to since I don't see
how you can tell it not to), and there was no errors. I then realised
that even though the classes specified were not available, puppet did
not complain on the client. That's a bit of a problem isn't it?

If I put an "include foo" in a node manifest, and foo doesn't exist,
puppet will complain. If I put "classes: foo" in an external node
script, and foo doesn't exist, puppet on the client does NOT complain.

Doug

[Nigel Kersten]

I actually just noticed this yesterday too. Definitely seems bug worthy, at a minimum there should be something notified client-side about it.

 

Doug

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To post to this group, send email to puppet...@googlegroups.com.
To unsubscribe from this group, send email to puppet-users...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.

--
nigel

[Douglas Garstang]

On Thu, May 27, 2010 at 2:51 PM, Nigel Kersten <nig...@google.com> wrote:
>
>
> On Thu, May 27, 2010 at 2:47 PM, Douglas Garstang <doug.g...@gmail.com>
> wrote:
>>
>> All,
>>
>> I just did a super simple test where I used the simple external nodes
>> script at http://docs.puppetlabs.com/guides/external_nodes.html.
>>
>> I ran it against an existing node (which you have to since I don't see
>> how you can tell it not to), and there was no errors. I then realised
>> that even though the classes specified were not available, puppet did
>> not complain on the client. That's a bit of a problem isn't it?
>>
>> If I put an "include foo" in a node manifest, and foo doesn't exist,
>> puppet will complain. If I put "classes: foo" in an external node
>> script, and foo doesn't exist, puppet on the client does NOT complain.
>
> I actually just noticed this yesterday too. Definitely seems bug worthy, at
> a minimum there should be something notified client-side about it.

Egads. I'd call it a complete deal breaker for external nodes.

Doug.

[Nigel Kersten]

Well that depends. I understand you're not happy about feeling like you've been  forced into using them, and I'm not defending the functionality at all, but it may not be a deal breaker for everyone.

I have presubmit hooks such that I can't create externally defined nodes that refer to classes that don't exist, and have unrecognized log message collation on my servers, so things like this leap out.