Standard process for patch submissions

0 views
Skip to first unread message

Dan Watling

unread,
Nov 2, 2009, 9:16:22 AM11/2/09
to PulpCore
Is there a standard process for patch submissions? I recently enhanced
the Button component to include a fourth state: disabled. Prior to my
change disabling the button only meant you couldn't click on it. With
my change it gets its own graphic to provide more visual feedback to
the user.

-Dan

David Brackeen

unread,
Nov 2, 2009, 10:32:15 AM11/2/09
to pulp...@googlegroups.com
There's no standard way, feel free to post a patch on the issues page or email to me.

Dan Watling

unread,
Nov 2, 2009, 1:48:14 PM11/2/09
to PulpCore
I've just e-mailed the full changes of Button.java to you.

I couldn't figure out how to create a patch file on Windows. I thought
'svn diff' would work, but when I ran the output of that through
'patch' (http://gnuwin32.sourceforge.net/packages/patch.htm) it didn't
work quite right.

-Dan

On Nov 2, 9:32 am, David Brackeen <brack...@gmail.com> wrote:
> There's no standard way, feel free to post a patch on the issues page or
> email to me.
>

David Brackeen

unread,
Nov 2, 2009, 2:14:07 PM11/2/09
to pulp...@googlegroups.com
What you sent works fine.
FWIW, I think both NetBeans and Eclipse (subclipse) both have patch creation from SVN.
Reply all
Reply to author
Forward
0 new messages