Some pull requests have broken the specs in psake. (We have 3 failing specs
at the moment.) After merging a pull request locally, you should run
./psake-buildTester.ps1 to ensure that all specs pass. New features and bug
fixes should include a spec too. Any volunteers to help fix the broken
specs? I fixed one out of three, but not sure when I'll be able to get
around to the other two.
We also have six open pull requests that need review and 17 issues that
require triage. Any volunteers?
James
--
James Kovacs, B.Sc., M.Sc.
http://jameskovacs.com jkov...@post.harvard.edu
@jameskovacs (Twitter)
403-397-3177 (mobile)
jameskovacs (Skype)
On Thu, Sep 27, 2012 at 8:45 PM, James Kovacs <jkov...@post.harvard.edu> wrote:
> Hi, everyone,
> Some pull requests have broken the specs in psake. (We have 3 failing specs
> at the moment.) After merging a pull request locally, you should run
> ./psake-buildTester.ps1 to ensure that all specs pass. New features and bug
> fixes should include a spec too. Any volunteers to help fix the broken
> specs? I fixed one out of three, but not sure when I'll be able to get
> around to the other two.
> We also have six open pull requests that need review and 17 issues that
> require triage. Any volunteers?
> --
> You received this message because you are subscribed to the Google Groups
> "psake-dev" group.
> To post to this group, send email to psake-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> psake-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/psake-dev?hl=en.
I was going to look at putting psake on CodeBetter CI (since I help run
it). I should have done it ages ago, but never got around to it. Given how
much I talk about CI, I feel like the cobbler's children have no shoes... :)
James
--
James Kovacs, B.Sc., M.Sc.
http://jameskovacs.com jkov...@post.harvard.edu
@jameskovacs (Twitter)
403-397-3177 (mobile)
jameskovacs (Skype)
On Fri, Sep 28, 2012 at 12:56 AM, Steve Wagner <li...@lanwin.de> wrote:
> Hi, what about integrating PSake to https://travis-ci.org/ or
> CodeBetter CI and send the failures to these list?
> On Thu, Sep 27, 2012 at 8:45 PM, James Kovacs <jkov...@post.harvard.edu>
> wrote:
> > Hi, everyone,
> > Some pull requests have broken the specs in psake. (We have 3 failing
> specs
> > at the moment.) After merging a pull request locally, you should run
> > ./psake-buildTester.ps1 to ensure that all specs pass. New features and
> bug
> > fixes should include a spec too. Any volunteers to help fix the broken
> > specs? I fixed one out of three, but not sure when I'll be able to get
> > around to the other two.
> > We also have six open pull requests that need review and 17 issues that
> > require triage. Any volunteers?
> > --
> > You received this message because you are subscribed to the Google Groups
> > "psake-dev" group.
> > To post to this group, send email to psake-dev@googlegroups.com.
> > To unsubscribe from this group, send email to
> > psake-dev+unsubscribe@googlegroups.com.
> > For more options, visit this group at
> > http://groups.google.com/group/psake-dev?hl=en.
> --
> You received this message because you are subscribed to the Google Groups
> "psake-dev" group.
> To post to this group, send email to psake-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> psake-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/psake-dev?hl=en.
I'm taking a stab at resolving these broken specs. I think I have writing_psake_variables_should_pass resolved. It was checking $config.framework -eq "3.5" which just wont always be true. For now, I've simply removed the check since it didn't seem to be adding anything to the verification of the spec. The other, executing_module_function_that_depends_on_another_module_should_pass, seems to be attempting to do some module importing in a way that is beyond my skill in powershell. Given that the spec was originally mis-named and wouldn't have been executed by the test suite, did this ever work? If my changes are acceptable, I'll submit a pull request for this and my non-ui host issue.
On Friday, September 28, 2012 1:09:30 PM UTC-4, James Kovacs wrote:
> I was going to look at putting psake on CodeBetter CI (since I help run > it). I should have done it ages ago, but never got around to it. Given how > much I talk about CI, I feel like the cobbler's children have no shoes... :)
> On Fri, Sep 28, 2012 at 12:56 AM, Steve Wagner <li...@lanwin.de<javascript:> > > wrote:
>> Hi, what about integrating PSake to https://travis-ci.org/ or >> CodeBetter CI and send the failures to these list?
>> On Thu, Sep 27, 2012 at 8:45 PM, James Kovacs <jko...@post.harvard.edu<javascript:>> >> wrote: >> > Hi, everyone,
>> > Some pull requests have broken the specs in psake. (We have 3 failing >> specs >> > at the moment.) After merging a pull request locally, you should run >> > ./psake-buildTester.ps1 to ensure that all specs pass. New features and >> bug >> > fixes should include a spec too. Any volunteers to help fix the broken >> > specs? I fixed one out of three, but not sure when I'll be able to get >> > around to the other two.
>> > We also have six open pull requests that need review and 17 issues that >> > require triage. Any volunteers?
>> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "psake-dev" group. >> > To post to this group, send email to psak...@googlegroups.com<javascript:> >> . >> > To unsubscribe from this group, send email to >> > psake-dev+...@googlegroups.com <javascript:>. >> > For more options, visit this group at >> > http://groups.google.com/group/psake-dev?hl=en.
>> -- >> You received this message because you are subscribed to the Google Groups >> "psake-dev" group. >> To post to this group, send email to psak...@googlegroups.com<javascript:> >> . >> To unsubscribe from this group, send email to >> psake-dev+...@googlegroups.com <javascript:>. >> For more options, visit this group at >> http://groups.google.com/group/psake-dev?hl=en.
> I'm taking a stab at resolving these broken specs. I think I have
> writing_psake_variables_should_pass resolved. It was checking
> $config.framework -eq "3.5" which just wont always be true. For now, I've
> simply removed the check since it didn't seem to be adding anything to the
> verification of the spec. The
> other, executing_module_function_that_depends_on_another_module_should_pass,
> seems to be attempting to do some module importing in a way that is beyond
> my skill in powershell. Given that the spec was originally mis-named and
> wouldn't have been executed by the test suite, did this ever work? If my
> changes are acceptable, I'll submit a pull request for this and my non-ui
> host issue.
> On Friday, September 28, 2012 1:09:30 PM UTC-4, James Kovacs wrote:
>> I was going to look at putting psake on CodeBetter CI (since I help run
>> it). I should have done it ages ago, but never got around to it. Given how
>> much I talk about CI, I feel like the cobbler's children have no shoes... :)
>> On Fri, Sep 28, 2012 at 12:56 AM, Steve Wagner <li...@lanwin.de> wrote:
>>> Hi, what about integrating PSake to https://travis-ci.org/ or
>>> CodeBetter CI and send the failures to these list?
>>> On Thu, Sep 27, 2012 at 8:45 PM, James Kovacs <jko...@post.harvard.edu>
>>> wrote:
>>> > Hi, everyone,
>>> > Some pull requests have broken the specs in psake. (We have 3 failing
>>> specs
>>> > at the moment.) After merging a pull request locally, you should run
>>> > ./psake-buildTester.ps1 to ensure that all specs pass. New features
>>> and bug
>>> > fixes should include a spec too. Any volunteers to help fix the broken
>>> > specs? I fixed one out of three, but not sure when I'll be able to get
>>> > around to the other two.
>>> > We also have six open pull requests that need review and 17 issues that
>>> > require triage. Any volunteers?
>>> > James
>>> > --
>>> > James Kovacs, B.Sc., M.Sc.
>>> > http://jameskovacs.com >>> > jko...@post.harvard.edu
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> Groups
>>> > "psake-dev" group.
>>> > To post to this group, send email to psak...@googlegroups.com.
>>> > To unsubscribe from this group, send email to
>>> > psake-dev+...@**googlegroups.com.
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "psake-dev" group.
>>> To post to this group, send email to psak...@googlegroups.com.
>>> To unsubscribe from this group, send email to psake-dev+...@**
>>> googlegroups.com.
> To post to this group, send email to psake-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> psake-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/psake-dev?hl=en.
So after some research, the commit that introduced that spec<https://github.com/psake/psake/commit/ba2363ba12b3684fc0fa3aade0182ee...> doesn't seem to have any other code associated with it. Since the commit doesnt seem to have any other code that would have fixed the potential issue it was testing, and the original author doesn't seem to be on this list, I'm going to go out on a limb and declare it bunk. All the specs are passing for me; A pull request has been submitted.
> On Sat, Sep 29, 2012 at 8:33 AM, Jeffrey Becker <jeffrey....@gmail.com<javascript:> > > wrote:
>> I'm taking a stab at resolving these broken specs. I think I have >> writing_psake_variables_should_pass resolved. It was checking >> $config.framework -eq "3.5" which just wont always be true. For now, I've >> simply removed the check since it didn't seem to be adding anything to the >> verification of the spec. The >> other, executing_module_function_that_depends_on_another_module_should_pass, >> seems to be attempting to do some module importing in a way that is beyond >> my skill in powershell. Given that the spec was originally mis-named and >> wouldn't have been executed by the test suite, did this ever work? If my >> changes are acceptable, I'll submit a pull request for this and my non-ui >> host issue.
>> On Friday, September 28, 2012 1:09:30 PM UTC-4, James Kovacs wrote:
>>> I was going to look at putting psake on CodeBetter CI (since I help run >>> it). I should have done it ages ago, but never got around to it. Given how >>> much I talk about CI, I feel like the cobbler's children have no shoes... :)
>>> James >>> -- >>> James Kovacs, B.Sc., M.Sc. >>> http://jameskovacs.com >>> jko...@post.harvard.edu
>>> On Fri, Sep 28, 2012 at 12:56 AM, Steve Wagner <li...@lanwin.de> wrote:
>>>> Hi, what about integrating PSake to https://travis-ci.org/ or >>>> CodeBetter CI and send the failures to these list?
>>>> On Thu, Sep 27, 2012 at 8:45 PM, James Kovacs <jko...@post.harvard.edu> >>>> wrote: >>>> > Hi, everyone,
>>>> > Some pull requests have broken the specs in psake. (We have 3 failing >>>> specs >>>> > at the moment.) After merging a pull request locally, you should run >>>> > ./psake-buildTester.ps1 to ensure that all specs pass. New features >>>> and bug >>>> > fixes should include a spec too. Any volunteers to help fix the broken >>>> > specs? I fixed one out of three, but not sure when I'll be able to get >>>> > around to the other two.
>>>> > We also have six open pull requests that need review and 17 issues >>>> that >>>> > require triage. Any volunteers?
>>>> > James >>>> > -- >>>> > James Kovacs, B.Sc., M.Sc. >>>> > http://jameskovacs.com >>>> > jko...@post.harvard.edu
>>>> > -- >>>> > You received this message because you are subscribed to the Google >>>> Groups >>>> > "psake-dev" group. >>>> > To post to this group, send email to psak...@googlegroups.com.
>>>> > To unsubscribe from this group, send email to >>>> > psake-dev+...@**googlegroups.com.
>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "psake-dev" group. >>>> To post to this group, send email to psak...@googlegroups.com. >>>> To unsubscribe from this group, send email to psake-dev+...@** >>>> googlegroups.com.
>> To post to this group, send email to psak...@googlegroups.com<javascript:> >> . >> To unsubscribe from this group, send email to >> psake-dev+...@googlegroups.com <javascript:>. >> For more options, visit this group at >> http://groups.google.com/group/psake-dev?hl=en.
