in case you want to compress (minify) the current 1.6.1 version and it doesn't work...

9 views
Skip to first unread message

Motig

unread,
Oct 19, 2009, 8:12:43 PM10/19/09
to Prototype & script.aculo.us
check these line numbers and add the semicolons there so the web
compressors and minifiers will work

line 314
timeout = timeout * 1000 << missing semicolon

line 1103
var CONCAT_ARGUMENTS_BUGGY = (function() {
return [].concat(arguments)[0][0] !== 1;
})(1,2) << missing semicolon

line 2880
})(document.createElement('div')) << missing semicolon

line 3422
name = p[i].name << missing semicolon

line 3549
propName = '_countedByPrototype',
value = 'x' << missing semicolon

...
uh i also posted a ticket so i hope the prototype team will make a
repaired version soon

T.J. Crowder

unread,
Oct 20, 2009, 10:57:41 AM10/20/09
to Prototype & script.aculo.us
Thank you for that. I know I ran into (and fixed) one of those in
trunk, thank you for taking the time to do the ticket and this thread.

Patches[1] are always welcome too. :-)

[1] http://prototypejs.org/contribute

Thanks again,
--
T.J. Crowder
Independent Software Consultant
tj / crowder software / com
www.crowdersoftware.com

Jim Higson

unread,
Oct 20, 2009, 11:06:00 AM10/20/09
to prototype-s...@googlegroups.com
On Tuesday 20 October 2009 01:12:43 Motig wrote:
> check these line numbers and add the semicolons there so the web
> compressors and minifiers will work

FWIW, yuicompressor handles 1.6.1 without issue. It gets very good compression
and has a proper JS parser (from Rhino) so it is very safe.

--
Jim
my wiki ajaxification thing: http://wikizzle.org
my blog: http://jimhigson.blogspot.com/

Buda

unread,
Oct 21, 2009, 10:59:43 AM10/21/09
to Prototype & script.aculo.us
To see all of missings and errors - try to test library in this online
tool
http://jsutility.pjoneil.net/

Tobie Langel

unread,
Oct 21, 2009, 12:30:13 PM10/21/09
to Prototype & script.aculo.us
Reply all
Reply to author
Forward
0 new messages