Python generated RPC service: Method not implemented.

Johan Euphrosine

unread,

Jul 11, 2008, 12:00:02 PM7/11/08

to Protocol Buffers

Hi,

http://code.google.com/apis/protocolbuffers/docs/reference/python-generated.html#service
suggests that generated methods are intended to be overridden by
subclasses

However when giving it a try:
http://proppy.aminche.com/hg/protobuf-test/file/d5912851a095/foo.py
http://proppy.aminche.com/hg/protobuf-test/file/d5912851a095/foo.proto
I got 'SetFailed: metMethod Bar not implemented.' instead of 'Bar'

Did I miss something or am I doing something wrong (stupid) ?

Thanks in advance.

Johan Euphrosine

unread,

Jul 11, 2008, 12:35:10 PM7/11/08

to Protocol Buffers

Hi again,

I believe the attached patch illustrate and correct this issue.

Hope I'm not doing something stupid.

--
bou ^

protobuf-service-reflection-callmethod-getattr.patch

Johan Euphrosine

unread,

Jul 13, 2008, 10:19:00 AM7/13/08

to Protocol Buffers

Hi,

I've released the patch in the public domain:
http://proppy.aminche.com/protobuf-service-reflection-callmethod-getattr.patch

Hope that helps.

--
bou ^

Johan Euphrosine

unread,

Jul 13, 2008, 10:34:12 AM7/13/08

to Protocol Buffers

I also opened an issue, with the patch attached at the following url:

http://code.google.com/p/protobuf/issues/detail?id=16

--
bou ^

Kenton Varda

unread,

Jul 15, 2008, 1:36:49 AM7/15/08

to Johan Euphrosine, Protocol Buffers

Thanks, I'll get this patch applied sometime this week.

Kenton Varda

unread,

Jul 16, 2008, 3:27:15 PM7/16/08

to Johan Euphrosine, Protocol Buffers

Hi Johan,

Our lawyers tell me that putting something in the public domain is actually not as easy as it appears. They suggest copying and pasting the text from this link to use as a declaration:

http://creativecommons.org/licenses/publicdomain/

Furthermore, the declaration has to appear somewhere where it will never disappear. The archives for this mailing list are probably sufficient, so you can just reply-all to this e-mail and paste the text in.

Alternatively, signing the CLA is still an option:

http://code.google.com/legal/individual-cla-v1.0.html

Sorry for all the red tape. I think it's silly too.

On Sun, Jul 13, 2008 at 7:19 AM, Johan Euphrosine <pro...@aminche.com> wrote:

Johan Euphrosine

unread,

Jul 18, 2008, 5:00:59 AM7/18/08

to Kenton Varda, Protocol Buffers

I added text from http://creativecommons.org/licenses/publicdomain/ to
the attached patch.

--
bou ^

protobuf-service-reflection-callmethod-getattr.patch

Kenton Varda

unread,

Jul 18, 2008, 12:35:49 PM7/18/08

to Johan Euphrosine, Protocol Buffers

Thanks, patch applied.

[CPR]-AL.exe

unread,

Jul 21, 2008, 8:07:28 AM7/21/08

to Protocol Buffers

Excuse me for my stupidity... but how can i apply a patch and what
file should i patch?

> >http://proppy.aminche.com/protobuf-service-reflection-callmethod-geta...

>
> > >> Hope that helps.
>
> > >> On Fri, Jul 11, 2008 at 6:35 PM, Johan Euphrosine <pro...@gmail.com>
> > >> wrote:
> > >> > Hi again,
>
> > >> > I believe the attached patch illustrate and correct this issue.
>
> > >> > Hope I'm not doing something stupid.
>
> > >> > On Fri, Jul 11, 2008 at 6:00 PM, Johan Euphrosine <pro...@gmail.com>
> > >> > wrote:
> > >> >> Hi,
>

> >http://code.google.com/apis/protocolbuffers/docs/reference/python-gen...

Johan Euphrosine

unread,

Jul 21, 2008, 8:14:31 AM7/21/08

to [CPR]-AL.exe, Protocol Buffers

This patch has already been applied to protobuf SVN trunk as shown on:
http://code.google.com/p/protobuf/source/detail?r=13

You can follow code checkout instruction on:
http://code.google.com/p/protobuf/source/checkout

Hope that helps.

2008/7/21 [CPR]-AL.exe <CPR.A...@gmail.com>:

--
bou ^

Reply all

Reply to author

Forward