Issue 428 in protobuf: Unable to compile the python module

[prot...@googlecode.com]

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 428 by novi...@gmail.com: Unable to compile the python module
http://code.google.com/p/protobuf/issues/detail?id=428

What steps will reproduce the problem?
1. python setup.py build

What is the expected output? What do you see instead?
The compilation of the python module throws an error about
an extraneous #else

What version of the product are you using? On what operating system?
Latest svn version of protocol-buffers
Python 2.7.3 (default, Apr 10 2012, 23:24:47) [MSC v.1500 64 bit (AMD64)]
on win32
Compiling with MSVC11

Please provide any additional information below.
The #else on lines 430 & 460 of python-proto2.cc appears to be erroneous,
along with the unmatched if statement immediately below it

if (descriptor->file()->options().cc_api_version() == 2 &&
descriptor->type() == google::protobuf::FieldDescriptor::TYPE_STRING)
{

Deleting lines 430-432 & 460-462 seems to allow the compile
to finish & the module appears to work.

http://code.google.com/p/protobuf/source/browse/trunk/python/google/protobuf/pyext/python-proto2.cc#430

[prot...@googlecode.com]

Updates:
Status: Accepted
Owner: xiaof...@google.com

Comment #1 on issue 428 by xiaof...@google.com: Unable to compile the
python module
http://code.google.com/p/protobuf/issues/detail?id=428

(No comment was entered for this change.)

[prot...@googlecode.com]

Updates:
Status: Started

Comment #2 on issue 428 by xiaof...@google.com: Unable to compile the

[prot...@googlecode.com]

Updates:
Status: Fixed
Labels: FixedIn-2.5.0

Comment #3 on issue 428 by xiaof...@google.com: Unable to compile the
python module
http://code.google.com/p/protobuf/issues/detail?id=428

Fixed in r435.