Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Protocol Buffers
Home
+ new post
About this group
Join this group
Message from discussion Issue 81 in protobuf: Maven Protoc Plugin Code Review
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
proto...@googlecode.com  
View profile  
 More options Feb 14 2010, 11:11 am
From: proto...@googlecode.com
Date: Sun, 14 Feb 2010 16:11:55 +0000
Local: Sun, Feb 14 2010 11:11 am
Subject: Re: Issue 81 in protobuf: Maven Protoc Plugin Code Review
Print | View thread | Show original | Report this message | Find messages by this author

Comment #15 on issue 81 by supercargo: Maven Protoc Plugin Code Review
http://code.google.com/p/protobuf/issues/detail?id=81

I have found a bug in the way that the derivedProtopathElements get  
calculated.  It
is assumed that all the dependency artifacts will be files (specifically  
jar files)
but this is not the case when doing a reactor (multi-module) build.

For reactor builds, the compile artifacts can be directories, e.g.,  
target/classes,
from other modules that were built as part of the same mvn invocation.

I'd like to second the comment that I don't really see the need to always  
be looking
in dependency jars for .proto files.  If I'm depending on an artifact with  
proto
files, why would I assume that the java bindings were not generated and  
included in
that dependency's jar?  My preference would be to require transitive  
sources of proto
files be listed explicitly in the plugin config.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google