Maven (and minor bug)

22 views
Skip to first unread message

Eric Turcotte

unread,
May 19, 2011, 1:05:33 PM5/19/11
to project-voldemort
Is anyone still working on coveting the project to Maven? Is this a
possibility so it can be available on Maven Central? I'd like to work
on this effort.

Also I ran into a bug while doing some local testing on Windows. It
came up when running RebalanceCLI. The filter class is sent from
AdminClient to the server where is tries to load it via
NetworkClassLoader. NetworkClassLoader.dumpClass() uses
File.separatorChar which causes Java to try to load the class file
through the file system on Windows. It is expecting the JAR to be
exploded in the directory where the startup script is run. Switching
this to '/' fixes the issue because the class file is found in the
JAR. This would not change behavior on *nix system obviously and it
is a minor change. Do you need a patch for this or can one of the
committers make the change? There isn't a specific test for
dumpClass().

Thanks,
Eric

Sunny Gleason

unread,
May 19, 2011, 2:10:30 PM5/19/11
to project-...@googlegroups.com
+1, I'd love to see the Maven thing happen

Bonus points if there's separate jars for api and
implementation to help make it easy for storage
engine implementors... :)

Willing to pitch in as well,

-Sunny

Eric Turcotte

unread,
May 19, 2011, 5:09:23 PM5/19/11
to project-voldemort
Organizing the project into submodules makes it a little easier to
build the individual components. Maven 3's has the parallel build
feature but this project builds fast already. It's easy to get
carried away with splitting the project into submodules though. There
could be client, core, server, store api, serialization api, 1 for
each contrib folder, 1 for each type of store, etc. Any thoughts on
the right level of granularity?

On May 19, 1:10 pm, Sunny Gleason <sunny.glea...@gmail.com> wrote:
> +1, I'd love to see the Maven thing happen
>
> Bonus points if there's separate jars for api and
> implementation to help make it easy for storage
> engine implementors...  :)
>
> Willing to pitch in as well,
>
> -Sunny
>

Sunny Gleason

unread,
May 19, 2011, 5:18:57 PM5/19/11
to project-...@googlegroups.com
To start, I'm happy with any mavenization at all.

It would be great to see the storage api broken out,
but when I tried to do this on my own a couple months
ago, I discovered that the code is not quite in the
proper shape to do that right now (a lot of cross-package
dependencies).

So I guess I'm saying: whatever the maintainers are
willing to commit to as a first step, I'll be very happy
with... :)

-Sunny

> --
> You received this message because you are subscribed to the Google Groups
> "project-voldemort" group.
> To post to this group, send email to project-...@googlegroups.com.
> To unsubscribe from this group, send email to
> project-voldem...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/project-voldemort?hl=en.
>
>

Alex Feinberg

unread,
May 19, 2011, 5:19:43 PM5/19/11
to project-...@googlegroups.com
I'd love to see a maven version, or at least the ability generate a
pom.xml reliably from ant

If someone wants to contribute a patch, that would be great.

However, a whole-sale mavenification may be difficult: my suggestion
is to either generate a pom.xml or consider ivy

(No specific bias for or against maven, just it's generally difficult
to mavenize an existing ant project)

Good catch on the file separator: unfortunately we don't have any
Windows machine to test this on. Feel free to make a pull request.

Thanks,
- Alex

Reply all
Reply to author
Forward
0 new messages