[2.3 java] jpa as default: what about a finder?

[Andreas]

Hi,

we are about to start a project with play 2.2-java right now.

With 2.3 the ebean stack is going to be seperated into a plugin and jpa is going to become the standard implementation like on 1.x again.

Question:
Will there be a finder like concept with 2.3-jpa on ebean? The finder of ebean is really nice and with jpa we would like to have that feature as well.

Kind regards
Andreas

[Christopher Hunt]

My gut reaction here is that we would not want to do anything over and above what JPA provides out of the box. That said, we'd re-evaluate closer to the time.

[Andreas]

My guess is, that a JPA support similar powerful to the one of Play 1, would promote Play 2's java stack.
At the moment Play 2's JPA implementation is more "raw" than the one in Play 1, making the usage of the platform more "manual" and the "ramp-up" to create something quickly more heavy.

I guess what would be nice (or needed) is:

• The functionality of Model and GenericModel to implement the basics like save() etc.
  
• A finder, similar to the one of ebean (typesafe or not), best case in some kind of builder pattern.
  

The alternative is, that everybody is implementing these fundamentals for himself.

[Marcos Pereira]

Just write this Model with Finder/Query support. 

https://gist.github.com/marcospereira/044ec48bb70468097396

What do you guys thing? Is it useful? Does it respect JPA Criteria API?

HTH

--
http://about.me/marcospereira

--
You received this message because you are subscribed to the Google Groups "play-framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framewor...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Andreas]

Bom dia Marcos,

looks actually like the concept needed in Play2@JPA!! Thanks a lot for your input!

The only thing we would add is a possibility to add criterias in brackets and custom criterias like:

1. brackets:
   WHERE/AND ( obj.name LIKE '%abc%' OR obj.description LIKE '%abc%' OR obj.comment LIKE '%abc%')
   
   In an API like where().or(new ..., new...., new..)
   
   
2. custom predefined criterias:
   WHERE/AND (obj.organisation IN ( SELECT organisation FROM abc WHERE ...)
   
   In an API like where().addStringCondition(....)
   

What do you think?
Best regards
Andreas

[Marcos Pereira]

Hi, comments inline...

--
http://about.me/marcospereira

On Mon, Oct 14, 2013 at 8:22 AM, Andreas <web...@gmail.com> wrote:

Bom dia Marcos,

Bom dia. :-)

 

looks actually like the concept needed in Play2@JPA!! Thanks a lot for your input!

Thanks. But keep in mind that this is a very incomplete and untested implementation.

 

The only thing we would add is a possibility to add criterias in brackets and custom criterias like:

1. brackets:
   WHERE/AND ( obj.name LIKE '%abc%' OR obj.description LIKE '%abc%' OR obj.comment LIKE '%abc%')
   
   In an API like where().or(new ..., new...., new..)
   

I think that this is very easy to do. Just redefine the method "or" in "Query" class to accept varargs (since Restrictions API supports varargs in or method). 

1. custom predefined criterias:
   WHERE/AND (obj.organisation IN ( SELECT organisation FROM abc WHERE ...)
   
   In an API like where().addStringCondition(....)
   

Same thing here:

http://docs.jboss.org/hibernate/orm/4.3/javadocs/org/hibernate/criterion/Restrictions.html#sqlRestriction(java.lang.String) 

What do you think?

HTH

[Andreas]

Hi,

we will use your implementation as a bootstrap, implement the generic use cases missing and add some test coverage.
When we are finished, we will convey the implementation in this discussion.

Best regards, Andreas

[Loic]

I agree, it would be great to have a good JPA support

JPA support in Play was really nice

[Loic]

"JPA support in Play was really nice" <- I mean in Play 1 :)

[Jens Jäger]

Hi Marcos,

in my project I did some polishing on your gist the results are pushed to https://github.com/jensjaeger/play4jpa

Thanks for sharing your code.

Jens