Intent to release 1.9.1

177 views
Skip to first unread message

Ariya Hidayat

unread,
Jun 1, 2013, 12:08:59 PM6/1/13
to phan...@googlegroups.com
Hi folks,

Long overdue, I'd like to roll out 1.9.1 since it contains some
important fixes (backported from master). You can see the changes at
https://github.com/ariya/phantomjs/compare/1.9.0...1.9.

Unfortunately, running the unit tests reveal some failures there. It
could be just flaky behavior, it could be also real regressions.

I plan to spend the weekend trying to isolate the issues. However, if
someone beats me to it, I'd be a happy man. In any cases, all kind of
help is appreciated.

Thank you!


Best regards,


--
Ariya Hidayat, http://ariya.ofilabs.com
http://twitter.com/ariyahidayat
http://gplus.to/ariyahidayat

Nicolas Perriault

unread,
Jun 1, 2013, 2:17:58 PM6/1/13
to phan...@googlegroups.com
On Sat, Jun 1, 2013 at 6:08 PM, Ariya Hidayat <ariya....@gmail.com> wrote:

> I plan to spend the weekend trying to isolate the issues. However, if
> someone beats me to it, I'd be a happy man. In any cases, all kind of
> help is appreciated.

For what it's worth, a fresh PhantomJS compiled from the 1.9 branch
doesn't break the CasperJS build.

Hope it helps

++

--
Nicolas Perriault
https://nicolas.perriault.net/
Phone: +33 (0) 660 92 08 67

Ariya Hidayat

unread,
Jun 2, 2013, 12:07:07 PM6/2/13
to phan...@googlegroups.com
> For what it's worth, a fresh PhantomJS compiled from the 1.9 branch
> doesn't break the CasperJS build.

Thanks Nicolas, that's very useful indeed.

Another good news: the test failures are just flakiness and I've since
fixed them. Just a few more failures to go before we're cleared for a
release.

Ariya Hidayat

unread,
Jun 2, 2013, 10:07:46 PM6/2/13
to phan...@googlegroups.com
The remaining tests flakiness is something I won't bother fixing now.
Perhaps once we have a brand-new and much more solid setup for the
test suite, we shall revisit that again.

I'll likely tag 1.9.1 tomorrow unless there's a last-minute issue.


Regards,

Ariya Hidayat

unread,
Jun 6, 2013, 2:39:11 AM6/6/13
to phan...@googlegroups.com
It's finally out! You can grab the source and the premade binaries.

For your convenience, the changes are also listed here:

* Fixed problems with specifying proxy server (issue 10811, 11117)
* Fixed UTF-8 encoding with system.stdout and system.stderr (issue 11162)
* Ensured that onResourceReceived will be always invoked (issue 11163)
* Fixed module loading from an absolute path on Windows (issue 11165)
* Fixed typo in the command-line option for setting the cache size (11219)
* Fixed possible crash when handling network requests (issue 11252, 11338)


Thanks to everyone who helped with this patch release! Now, spread the
love please :)


Best regards,
Reply all
Reply to author
Forward
0 new messages