Broke link

[Hitoshi Harada]

It seems the URLs for distributions with -{something} suffix version is broken.

http://pgxn.org/dist/plv8/1.1.0-beta1/

It says to me "Resource not found".  Can we fix it?

Thanks,

--
Hitoshi Harada

[David E. Wheeler]

On Apr 29, 2013, at 2:17 AM, Hitoshi Harada <umi.t...@gmail.com> wrote:

> It seems the URLs for distributions with -{something} suffix version is broken.
>
> http://pgxn.org/dist/plv8/1.1.0-beta1/
>
> It says to me "Resource not found". Can we fix it?

Yes, it's on my list. The thing is that the format of semantic versions changed. The hyphen is now required, but older semvers without it are still supported. I need to go over all the code to sync things up, add redirects as appropriate, etc. Bit of a PITA.

In the meantime, I believe that if you make the version with the hyphen, it will work. In other words, if the next release was "1.1.0-beta2", rather than "1.1.0beta2", all the links would work.

Apologies for the hassle.

Best,

David

[Daniele Varrazzo]

On Mon, Apr 29, 2013 at 6:24 PM, David E. Wheeler <da...@justatheory.com> wrote:
>
> Yes, it's on my list. The thing is that the format of semantic versions changed. The hyphen is now required, but older semvers without it are still supported. I need to go over all the code to sync things up, add redirects as appropriate, etc. Bit of a PITA.

Anything I should know client-side? Can you put together a test suite
of what syntax is accepted, what not, and if there is some
normalization rule to be applied etc. (Perl is fine of course:
whatever test suite you have for server side will be ported to the
client to check we agree on what's an 1.0).

Cheers,

-- Daniele

[David E. Wheeler]

On Apr 29, 2013, at 12:11 PM, Daniele Varrazzo <daniele....@gmail.com> wrote:

> Anything I should know client-side? Can you put together a test suite
> of what syntax is accepted, what not, and if there is some
> normalization rule to be applied etc. (Perl is fine of course:
> whatever test suite you have for server side will be ported to the
> client to check we agree on what's an 1.0).

So it is the same as before, except that "-" is required between the patch level and the prerelease string. For backwards compatibility, the SemVer Perl module and the semver data type allow input without the "-", but will add it for display. The relevant commit for the Perl module and its tests is here:

https://github.com/theory/semver/commit/1e0fcc22b5fe879b902d5161ea3eb4b77a24d848

The tests themselves:

https://github.com/theory/semver/blob/master/t/base.t

And for the semver data type, the changes were (mostly) here:

https://github.com/theory/pg-semver/pull/6/files

And the tests:

https://github.com/theory/pg-semver/blob/master/test/sql/base.sql

In both cases, I tried to offer an interface that requires the hyphen, and one that does not, but it is always include in the output. The upshot is that "1.1.0b1" should be converted to "1.1.0-b1" for output, and considered equivalent.

I think that, for the client, until I fix the broken semvers in the index, you would need to do both. After they're fixed, my expectation is that there would be none without the hyphen, after which you could be strict again. I likely won't be able to clean that stuff up until sometime after PGCon, though.

Best,

David

[Daniele Varrazzo]

On Apr 30, 4:19 am, "David E. Wheeler" <da...@justatheory.com> wrote:

> On Apr 29, 2013, at 12:11 PM, Daniele Varrazzo <daniele.varra...@gmail.com> wrote:
>
> > Anything I should know client-side? Can you put together a test suite
> > of what syntax is accepted, what not, and if there is some
> > normalization rule to be applied etc. (Perl is fine of course:
> > whatever test suite you have for server side will be ported to the
> > client to check we agree on what's an 1.0).
>
> So it is the same as before, except that "-" is required between the patch level and the prerelease string. For backwards compatibility, the SemVer Perl module and the semver data type allow input without the "-", but will add it for display.

I've released PGXN Client 1.2.1, which should allow interaction with
modules both with and without hyphen. Testing is very welcome.

-- Daniele

[Hitoshi Harada]

PGXN Client 1.2.1 works for me.  Thanks!
 

--
Hitoshi Harada