X-Reproxy-Host patch, take 2

[Logan Bowers]

Hello all, 

Per a request from Brad, I've uploaded my previous patch to codereview.appspot.com for easy inspection.  In short, this patch allows a web server responding with an X-REPROXY-URL header to also include X-REPROXY-HOST header.  X-REPROXY-HOST sets the HTTP Host header during the reproxy request, making it possible to, e.g., redirect to a vhost.  In all, I think the change is ~5 lines.  

The Code Review URL is http://codereview.appspot.com/2473, ya'll want to take a look?  

Logan Bowers 

[Brad Fitzpatrick]

How did you upload the patch to codereview?  It seems to have gotten mangled.  For instance:

http://codereview.appspot.com/2473/diff/1/3

See the error at bottom?  Did you use the upload tool, or by hand?

In any case, I was going to leave a comment about you not having a space after your comma, but that's as far as I got.

[Logan Bowers]

I uploaded it directly; I tried using the upload script but it just spit out the error, "Unrecognized svn project root: http://code.sixapart.com/svn/perlbal/trunk" and I didn't really take the time to investigate why.  

It looks like the world had just moved on and my patch was out of date.  I did an 'svn up' and generated a new diff; that appears to have fixed the problem.  Patch Set 4 should diff nicely and includes the comma-space fix.  

Oh, and that you cannot delete patch sets: mildly irritating (i.e. ignore patch sets 2 and 3).  

Logan Bowers

[Brad Fitzpatrick]

I added http://code.sixapart.com/svn/perlbal/trunk as a repo on codereview.appspot.com.  Next time try the script again and let me know how it goes.

[Nick Andrew]

On Wed, Jul 02, 2008 at 07:57:41PM -0700, Brad Fitzpatrick wrote:
> I added http://code.sixapart.com/svn/perlbal/trunk as a repo on
> codereview.appspot.com. Next time try the script again and let me know how
> it goes.

perlbal's in there twice ...

http://codereview.appspot.com/repos

[bottom]
Repository: perlbal trunk
*trunk* Trunk http://code.sixapart.com/svn/perlbal/trunk/trunk/

Nick.
--
PGP Key ID = 0x418487E7 http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A 67E3 6266 6EB9 4184 87E7

[Logan Bowers]

Hello all,

Thanks to the folks who reviewed the patch on Code Review. I haven't
heard received any negative feedback or requests for changes. Unless
anyone has some changes they'd like me to make, can one of ya'll with
the commit bit be willing to add it to the tree? Thanks!

Logan Bowers

> --~--~---------~--~----~------------~-------~--~----~
> You received this message because you are subscribed to the Google
> Groups "perlbal" group.
> To post to this group, send email to per...@googlegroups.com
> To unsubscribe from this group, send email to perlbal-u...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/perlbal?hl=en
> -~----------~----~----~----~------~----~------~--~---
>