Newsgroups: perl.perl6.internals
Path: archiver1.google.com!news1.google.com!newsfeed.stanford.edu!nntp.perl.org
Return-Path: <s...@amnh.org>
Mailing-List: contact perl6-internals-h...@perl.org; run by ezmlm
Delivered-To: mailing list perl6-intern...@perl.org
Delivered-To: perl6-intern...@perl.org
X-Authentication-Warning: egg.amnh.org: scog owned process doing -bs
Date: Thu, 20 Feb 2003 21:07:51 -0500 (EST)
To: Nicholas Clark <n...@unfortu.net>
cc: perl6-intern...@perl.org
Subject: Re: Configure.pl --cgoto=0  doesn't work
In-Reply-To: <20030220213957.GC281@Bagpuss.unfortu.net>
Message-ID: <Pine.GSO.4.43.0302202055540.8345-100000@egg.amnh.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SMTPD: qpsmtpd/0.21-dev, http://develooper.com/code/qpsmtpd/
X-Spam-Check-By: one.develooper.com
X-Spam-Status: No, hits=-1.3 required=7.0 tests=CARRIAGE_RETURNS,IN_REP_TO,QUOTED_EMAIL_TEXT,SPAM_PHRASE_00_01,SUPERLONG_LINE,USER_AGENT_PINE,X_AUTH_WARNING version=2.44
X-SMTPD: qpsmtpd/0.20, http://develooper.com/code/qpsmtpd/
Approved: n...@nntp.perl.org
From: s...@amnh.org (Simon Glover)
References: <20030220213957.GC281@Bagpuss.unfortu.net>
Lines: 38


On Thu, 20 Feb 2003, Nicholas Clark wrote:

> If I
>
> perl Configure.pl --cgoto=0 && make all test
>
> then the build fails with:
>
> ccache /usr/local/bin/gcc -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H  -I/usr/local/include  -Wall -Wstrict-prototypes -Wmissing-prototypes -Winline -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Waggregate-return -Winline -W -Wno-unused -Wsign-compare -Wformat-nonliteral -Wformat-security -Wpacked -Wpadded -Wdisabled-optimization  -I./include  -DHAS_JIT -DI386 -o jit_cpu.o -c jit_cpu.c
> In file included from jit_cpu.c:39:
> include/parrot/jit_emit.h:2302:39: parrot/oplib/core_ops_cgp.h: No such file or directory
> In file included from jit_cpu.c:39:
> include/parrot/jit_emit.h: In function `Parrot_jit_begin':
> include/parrot/jit_emit.h:2349: `cgp_core' undeclared (first use in this function)
> include/parrot/jit_emit.h:2349: (Each undeclared identifier is reported only once
> include/parrot/jit_emit.h:2349: for each function it appears in.)
> *** Error code 1

 The problem is that an ifdef in jit/i386/jit_emit.h is defining JIT_CGP
 based on whether or not the compiler is GCC, and not on whether
 HAS_COMPUTED_GOTO is defined. The attached patch fixes this, but I'm
 not sure if the __GCC__ bit is still necessary. Leo?

 Simon

--- jit/i386/jit_emit.h.old	Thu Feb 20 20:59:11 2003
+++ jit/i386/jit_emit.h	Thu Feb 20 20:58:52 2003
@@ -8,7 +8,7 @@

 #include <assert.h>

-#ifdef __GNUC__
+#if defined HAS_COMPUTED_GOTO && defined __GCC__
 #  define JIT_CGP
 #endif