                                                                                                                                                                                                                                                                
Newsgroups: perl.perl6.internals
Path: archiver1.google.com!news2.google.com!news.maxwell.syr.edu!newsfeed.stanford.edu!nntp.perl.org
Mailing-List: contact perl6-internals-h...@perl.org; run by ezmlm
In-Reply-To: <20040110195444.GE94211@plum.flirble.org>
References: <20040105134753.GA2215@babylonia.flatirons.org> <200401051443.i05EhD002717@thu8.leo.home> <20040108044755.GA10036@babylonia.flatirons.org> <200401081549.i08FnFa25512@thu8.leo.home> <20040109133754.GB7902@babylonia.flatirons.org> <200401101328.i0ADSc016425@thu8.leo.home> <20040110160831.GH11136@plum.flirble.org> <200401101939.i0AJdpC24457@thu8.leo.home> <20040110195444.GE94211@plum.flirble.org>
Mime-Version: 1.0 (Apple Message framework v606)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-ID: <BA2664DC-43CC-11D8-89C6-000393A6B9DA@mac.com>
Content-Transfer-Encoding: 7bit
Cc: perl6-intern...@perl.org, Leopold Toetsch <l...@toetsch.at>
Subject: Re: [PATCH] The Return of the Priority DOD
Date: Sat, 10 Jan 2004 16:25:58 -0800
To: Nicholas Clark <n...@ccl4.org>
Approved: n...@nntp.perl.org
From: jcli...@mac.com (Jeff Clites)


On Jan 10, 2004, at 11:54 AM, Nicholas Clark wrote:

> On Sat, Jan 10, 2004 at 08:39:51PM +0100, Leopold Toetsch wrote:
>> Nicholas Clark <n...@ccl4.org> wrote:
>>
>>> src/dod.c: In function `clear_live_bits':
>>> src/dod.c:755: `cur_arena' undeclared (first use in this function)
>>
>>> The appended patch cures it (and all tests pass) but I'm not sure if 
>>> it
>>> is correct.
>>
>> Ah yep, thanks. I didn't test the patch with ARENA_DOD_FLAGS disabled
>> and finally diceded that "arena" is as meaningful and readable as
>> "cur_arena" and changed that before submitting - a policy which almost
>> always causes an error somewhere :)
>
> How come most tinderboxes kept going without failing? What's making the
> choice on the value of ARENA_DOD_FLAGS ?

It gets set in include/parrot/pobj.h, and is basically set to true if 
your platform has some flavor of memalign(), which allows you to 
allocate chunks of memory with arbitrary power-of-2 alignment. So all 
the platforms being tested on the tinders probably have this. (Of 
course, you can manually set ARENA_DOD_FLAGS to false in the source, 
for testing.)

JEff