Message from discussion
cvs commit: parrot/src interpreter.c
Newsgroups: perl.perl6.internals
Path: archiver1.google.com!news2.google.com!news.maxwell.syr.edu!newsfeed.stanford.edu!nntp.perl.org
Return-Path: <j...@hitchhiker.org>
Mailing-List: contact perl6-internals-h...@perl.org; run by ezmlm
Delivered-To: mailing list perl6-intern...@perl.org
Received: (qmail 26708 invoked by uid 76); 9 Mar 2004 05:05:20 -0000
Received: from x1.develooper.com (HELO x1.develooper.com) (63.251.223.170)
by onion.perl.org (qpsmtpd/0.27-dev) with SMTP; Mon, 08 Mar 2004 21:05:20 -0800
Received: (qmail 4267 invoked by uid 225); 9 Mar 2004 05:05:16 -0000
Delivered-To: perl6-intern...@perl.org
Received: (qmail 3648 invoked by alias); 9 Mar 2004 05:04:03 -0000
Received: from [64.252.113.201] (HELO galactic.hitchhiker.org) (64.252.113.201)
by la.mx.develooper.com (qpsmtpd/0.27-dev) with ESMTP; Mon, 08 Mar 2004 21:04:03 -0800
Received: from galactic.hitchhiker.org (josh@localhost [127.0.0.1])
by galactic.hitchhiker.org (8.12.11.Beta0/8.12.11.Beta0/Debian-2) with ESMTP id i2953tTu004667;
Tue, 9 Mar 2004 00:03:55 -0500
Received: from galactic.hitchhiker.org (josh@localhost)
by galactic.hitchhiker.org (8.12.11.Beta0/8.12.11.Beta0/Debian-2) with ESMTP id i2953s5H004660;
Tue, 9 Mar 2004 00:03:54 -0500
Message-ID: <200403090503.i2953s5H004660@galactic.hitchhiker.org>
X-Mailer: exmh version 2.5 07/13/2001 (debian 2.5-1) with nmh-1.1-RC1
To: Jens Rieks <par...@jensbeimsurfen.de>
cc: perl6-intern...@perl.org
Reply-To: Josh Wilmes <j...@hitchhiker.org>
Subject: Re: cvs commit: parrot/src interpreter.c
In-Reply-To: Your message of "Tue, 09 Mar 2004 05:00:16 +0100."
<200403090459.54782.parrot@jensbeimsurfen.de>
References: <20040309032412.9824.qmail@x1.develooper.com> <200403090459.54782.parrot@jensbeimsurfen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 09 Mar 2004 00:03:54 -0500
Sender: j...@hitchhiker.org
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on x1.develooper.com
X-Spam-Status: No, hits=-4.9 required=8.0 tests=BAYES_00 autolearn=ham
version=2.63
Approved: n...@nntp.perl.org
From: j...@hitchhiker.org (Josh Wilmes)
Sorry, typo- I have no idea how that got by.
--Josh
At 5:00 on 03/09/2004 +0100, Jens Rieks <par...@jensbeimsurfen.de> wrote:
> Hi,
>
> On Tuesday 09 March 2004 04:24, Josh Wilmes wrote:
> > cvsuser 04/03/08 19:24:12
> >
> > Modified: src interpreter.c
> > Log:
> > Missing function/data casts.
> >
> > Revision Changes Path
> > 1.279 +3 -3 parrot/src/interpreter.c
> >
> > Index: interpreter.c
> > ===================================================================
> > RCS file: /cvs/public/parrot/src/interpreter.c,v
> > retrieving revision 1.278
> > retrieving revision 1.279
> > diff -u -w -r1.278 -r1.279
> > --- interpreter.c 6 Mar 2004 14:26:08 -0000 1.278
> > +++ interpreter.c 9 Mar 2004 03:24:12 -0000 1.279
> > @@ -1,7 +1,7 @@
> > /*
> >
> > ###########################################################################
> >##### Copyright: 2001-2003 The Perl Foundation. All Rights Reserved. -$Id:
> > interpreter.c,v 1.278 2004/03/06 14:26:08 leo Exp $
> > +$Id: interpreter.c,v 1.279 2004/03/09 03:24:12 josh Exp $
> >
> > ###########################################################################
> >#####
> >
> > =head1 NAME
> > @@ -1520,7 +1520,7 @@
> > interpreter->evc_func_table = mem_sys_allocate(sizeof(void *) *
> > n); for (i = 0; i < n; ++i)
> > interpreter->evc_func_table[i] = (op_func_t)
> > - ((void**)lib->op_func_table)[CORE_OPS_check_events__];
> > +
> > DTOFPTR(((void**)lib->op_func_table)[CORE_OPS_check_events__]); }
> What is that supposed to do? It seems to be something platform specific..?
> --> http://tinderbox.perl.org/tinderbox/bdshowbuild.cgi?tree=parrot
>
> > }
> >
> > @@ -2243,7 +2243,7 @@
> > if ((int)interpreter->run_core == cg_lib->core_type) {
> > for (i = n_old; i < n_tot; ++i)
> > interpreter->evc_func_table[i] =
> > - (op_func_t)ops_addr[CORE_OPS_check_events__];
> > + (op_func_t)DTOFPTR(ops_addr[CORE_OPS_check_events__]);
> > interpreter->save_func_table = (void *) ops_addr;
> > }
> > /*
>
> jens