Re: [perl #31975] [PATCH] non-vtable methods on builtin pmcs

[Chromatic]

On Wed, 2004-10-13 at 13:33, Sam Ruby wrote:

> Index: lib/Parrot/Pmc2c.pm

> +sub proto ($$) {
> + my ($type, $parameters) = @_;

If these are methods (and this appears to be a class method), you can
leave off the function prototype; Perl doesn't do anything with it:

sub proto {
my ($type, $parameters) = @_;

It's not a bad thing to have, but it goes unused. I'd remove it,
especially because the method documentation does a better job of
explaining the expected parameters already.

[Leopold Toetsch]

Sam Ruby <parrotbug...@parrotcode.org> wrote:

> How about:

> METHOD INTVAL find(PMC* substr) {

Sure, we need a return value ;)

> Patch attached. Should the Object parameter be named "pmc" or "self"?

Great. I'd say for consistency "pmc".

> - Sam Ruby

Thanks, applied.
leo