Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[perl #24576] Some new targets in makefiles/root.in

6 views
Skip to first unread message

Juergen Boemmels

unread,
Dec 2, 2003, 11:14:46 AM12/2/03
to perl6-i...@perl.org, bugs-bi...@netlabs.develooper.com
Bernhard Schmalhofer (via RT) <bugs-...@netlabs.develooper.com> writes:

> languages.in:
> - add $(MAKE_C) befunge clean in target 'clean'
>
> root.in:
> - add target 'help': This should give a basic overview of what can be done
> with the Makefile
> - add target 'languages-clean': I needed that for testing
> - add target 'docs-clean': This seems to be consistent
> - add a '@' in 'flags-dummy': "Compiling with" should be printed only once
> - add target 'patch': generate a patch, when there are diffs to CVS, seems
> to be useful to me

All these items are good.

> I also did some reformating of lists in 'root.in'. This is of course a
> matter of taste.
> I don't like tabs in lists. As tabs have a defined meaning in targets, I
> find it confusing to see them in macro assignments.

This change touches many lines. This will invalidate many outstanding
patches, which often need to change root.in.

Anyway I think you are right, tabs don't belong in list definitions,
and I also like the convention using a single line per item; this
makes future diffs simpler.

If nobody objects to this I will apply this patch in 3 days (I think
this is a reasonable time)

bye
boe
--
Juergen Boemmels boem...@physik.uni-kl.de
Fachbereich Physik Tel: ++49-(0)631-205-2817
Universitaet Kaiserslautern Fax: ++49-(0)631-205-3906
PGP Key fingerprint = 9F 56 54 3D 45 C1 32 6F 23 F6 C7 2F 85 93 DD 47

Juergen Boemmels

unread,
Dec 5, 2003, 8:07:44 AM12/5/03
to perl6-i...@perl.org
> If nobody objects to this I will apply this patch in 3 days (I think
> this is a reasonable time)

Ok, time is up,
committed

0 new messages