Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[perl #32769] [PATCH] Standardizes and improves the formatting of internal_exception() calls

8 views
Skip to first unread message

James deBoer

unread,
Dec 2, 2004, 11:40:32 AM12/2/04
to bugs-bi...@rt.perl.org
# New Ticket Created by James deBoer
# Please include the string: [perl #32769]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=32769 >


Some calls to internal_exception will include a newline, others will
not. The effect of this is that
when some exceptions occur, parrot will exit without printing a newline,
which is ugly.

The fix I've attached is two-fold. First, it removes any newline passed
to internal_exception. (This was a search and replace, I may have missed
a few). Second, it modifies the the internal_exception function to print
a newline after printing the error.

- James


internal_exception.patch

James deBoer

unread,
Dec 2, 2004, 9:39:23 PM12/2/04
to perl6-i...@perl.org
D'oh,

It looks like I missed a few cases and broken the test suite with this
patch. I will post a new patch shortly.

-James

>------------------------------------------------------------------------
>
>
>
>

James deBoer

unread,
Dec 4, 2004, 3:50:36 PM12/4/04
to perl6-i...@perl.org
Here is take 2 of the patch.

In short, this patch:
- removes a newline from an internal_exception() call if it exists.
- modifies internal_exception() to print a newline after the debug message.
- modifies any test script that made use of internal exceptions

- James

internal_exception_take2.patch

Chromatic

unread,
Dec 12, 2004, 6:03:34 PM12/12/04
to James deBoer, perl6-i...@perl.org
On Sat, 2004-12-04 at 15:50 -0500, James deBoer wrote:

> Here is take 2 of the patch.
>
> In short, this patch:
> - removes a newline from an internal_exception() call if it exists.
> - modifies internal_exception() to print a newline after the debug message.
> - modifies any test script that made use of internal exceptions

Thanks, finally applied.

-- c

0 new messages