[perl #31860] [PATCH] Makefile cleanup
Will Coleda
# Please include the string: [perl #31860]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=31860 >
I tried to clear out some of dependency issues in Makefile, and got lost. Instead, you get:
Minor updates checked in to the root makefile (gen'd from config/gen/makefiles/root.in) to:
- don't treat parrotlib.pbc specially, but just like the other generated .pbc files. *
- Added in a missing dependency to the .imc -> .pbc rule I added earlier (need parrot built first, duh!)
- changed all the ./parrot's to .${slash}$(TEST_PROG) {arguably, the ./ should be included =in= TEST_PROG if necessary, though I don't personally use OS where this would break. At least it's a step in the right direction.}
Builds fine with:
make realclean;perl Configure.pl;make;make test
Regards.
* side effect of this is that we now build parrotlib.imc into library/, not include/. which makes sense to me, though I could be addled. This required updates to:
t/library/parrotlib.t
src/library.c
MANIFEST.generated
Because of these extra changes (outside of the Makefile), I've attached a patch instead of applying it directly - Leo/Dan? This ok? (if you like, I can apply it from my sandbox) Even if you don't like the change to parrotlib's directory, the other changes are safe.
Jens Rieks
> * side effect of this is that we now build parrotlib.imc into library/,
> not include/. which makes sense to me, though I could be addled. This
> required updates to:
and all hand written files to library/.
include/Getopt_Long.imc is deprecated, I've removed it (a newer version is
library/Getopt/Long.imc).
DWIM.imc is the last hand written file in include, I do not know what to do
with it.
jens
William Coleda
I don't care how the file came to be. If it's an .imc, I'm probably going to want
to include it. If it's a .pbc, I'm probably going to want to load_bytecode it. (Of course, this doesn't address the issue of which directory they're in =-)
As we go forward, we shouldn't even have to know /what/ directory these items are in, I suppose, if someone implements the outstanding TODO.
Which I guess is very long winded way of me saying, "eh." =-) Just let me know which parts of the patch (if any) get applied, how things /should/ be, and I can fix up what's left in the Makefile.
Leopold Toetsch
> DWIM.imc is the last hand written file in include, I do not know what to do
> with it.
It's used via the C<.include> directive, it's not a library. Being
generated or not isn't really important, the usage makes the difference.
> jens
leo
Leopold Toetsch
Could you please rediff & resend. AFAIK is most of the stuff already
done or changed under the hood - sorry.
leo