[perl #17233] [PATCH] misc:c: Parrot_vsprintf_s

[Leopold Toetsch]

# New Ticket Created by Leopold Toetsch
# Please include the string: [perl #17233]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=17233 >

- %x did return wrong "letters"
- this "continue" looks bogus,
I did a test with "...%x..", which works now.

Please apply.

-- attachment 1 ------------------------------------------------------
url: http://rt.perl.org/rt2/attach/37395/30314/4caa05/misc.c.diff

[Nicholas Clark]

On Fri, Sep 13, 2002 at 10:50:53AM +0000, Leopold Toetsch wrote:

> - %x did return wrong "letters"
> - this "continue" looks bogus,
> I did a test with "...%x..", which works now.
>
> Please apply.

Are you able to write a regression test that fails without your patch
applied?

Or is it more the case that all of Parrot_vsprintf_s is under-tested?

Nicholas Clark
--
Even better than the real thing: http://nms-cgi.sourceforge.net/

[Leopold Toetsch]

Nicholas Clark wrote:

> On Fri, Sep 13, 2002 at 10:50:53AM +0000, Leopold Toetsch wrote:
>
>
>>- %x did return wrong "letters"
>>- this "continue" looks bogus,
>>I did a test with "...%x..", which works now.
>>
>>Please apply.
>>
>
> Are you able to write a regression test that fails without your patch
> applied?

Attached (obsoletes/includes #17223)

> Or is it more the case that all of Parrot_vsprintf_s is under-tested?

Hm, not working at, all, %x wrong, %.<prec>s unimp, so definitely yes.
Please run the test first, then remove this continue, you'll see ;-)

So there could be some zig more tests on this, but I gave it a start.

> Nicholas Clark

leo