From cage/todo.pod:
Eliminate the C<< CONTEXT(interp->ctx)->foo >> usage in favor of
the much simpler C<< interp->ctx->foo >>, or similar simplification
Just my 2 pennies. :-)
Jonathan
> > Eliminate the C<< CONTEXT(interp->ctx)->foo >> usage in favor of
> > the much simpler C<< interp->ctx->foo >>, or similar simplification
> Yes, it's shorter and simpler but I'm not sure eliminating having some
> macro there is the Right Thing To Do. Already before now there has been
> discussion about making contexts garbage collectable. Wrapping access to
> the context in a macro means that such a move in the future would be
> easier, if that were to happen.
The attached patch (for review, and certainly not application until after the
0.6.0 release) changes CONTEXT(interp->ctx) to CONTEXT(interp), which seems
clearer to me.
All tests pass for me. Comments welcome.
-- c
The attached patch (for review, and certainly not application until
after the 0.6.0 release) changes CONTEXT(interp->ctx) to
CONTEXT(interp), which seems clearer to me.
Yes indeed.
All tests pass for me. Comments welcome.
-- c
Works for me in r26395 (but I only have x86/Linux available, so you
probably already knew that).
FWIW, the first five matches to "interp))" in the patch have double
parens around the "interp" arg.
-- Bob Rogers
http://rgrjr.dyndns.org/