Re: [perl #40253] [PATCH] always cast printf("%p") to (void *)

[Joshua Hoblitt]

What compiler is generating warnings?

-J

--
On Tue, Aug 29, 2006 at 07:03:44PM -0700, Will Coleda wrote:
> # New Ticket Created by Will Coleda
> # Please include the string: [perl #40253]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40253 >
>
>
> The attached patch casts all the printfs arguments corresponding to "%
> p" to be (void *), to avoid compiler warnings.
>
> However, the following tests fail after the change:
>
> Failed Test Stat Wstat Total Fail Failed List of Failed
> ------------------------------------------------------------------------
> -------
> t/dynoplibs/myops.t 1 256 7 1 14.29% 6
> t/examples/library.t 1 256 4 1 25.00% 3
> t/library/pcre.t 1 256 1 1 100.00% 1
>
> I leave it to the determined reader to figure out why. =-)
>

>
> --
> Will "Coke" Coleda
> wi...@coleda.com
>
>

[Will Coleda]

gcc 4.0.1, os x 10.4.7, PPC, ccflags .= " -pipe -fno-common -Wno-long-
double -Wno-long-long -std=c89 -pedantic ";

(which is still too many warnings, but leo noted this particular one
could stand to be fixed, as time permits.)

[Joshua Hoblitt]

Aww - I was wondering if it was gcc 4. gcc 3.4 seems to let that one by.

-J

--

[Paul Cochrane via RT]

On Tue Aug 29 19:03:44 2006, coke wrote:
> The attached patch casts all the printfs arguments corresponding to
"%
> p" to be (void *), to avoid compiler warnings.
>
> However, the following tests fail after the change:
>
> Failed Test Stat Wstat Total Fail Failed List of Failed
> ----------------------------------------------------------------------
--
> -------
> t/dynoplibs/myops.t 1 256 7 1 14.29% 6
> t/examples/library.t 1 256 4 1 25.00% 3
> t/library/pcre.t 1 256 1 1 100.00% 1
>
> I leave it to the determined reader to figure out why. =-)

Will,

I've managed to get almost all of the patch in (the part in src/
pmc_freeze.c gives the warning: cast discards qualifiers from pointer
target type), however I don't get the tests to fail (gcc 3.4.5, linux,
x86) and I don't see the warning messages you mention (other than the
extra one above). Do you still want this patch applied?

Paul

[Will Coleda]

Whatever you were able to apply is fine.

--

[Paul Cochrane via RT]

On Wed Dec 20 14:21:52 2006, coke wrote:
> Whatever you were able to apply is fine.

Applied in 16211, thanks!