Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

t/compilers/pge/p6regex/01-regex.t test 118 needs ICU?

4 views
Skip to first unread message

Bob Rogers

unread,
Jul 22, 2006, 8:54:36 PM7/22/06
to Patrick R. Michaud, parrot-...@perl.org
After building Parrot without ICU, 01-regex.t test 118 fails as
follows:

t/compilers/pge/p6regex/01-regex.........
# Failed test (t/compilers/pge/p6regex/01-regex.t at line 59)
# got: 'no ICU lib loaded
# current instr.: 'parrot;PGE::Grammar;_regex_corou' pc 118 (EVAL_1:51)
# called from Sub 'parrot;PGE::Grammar;_regex' pc 20 (EVAL_1:8)
# called from Sub '_PGE_Test' pc 34 (/usr/src/parrot/t/compilers/pge/p6regex/01-regex_118.pir:18)
# '
# expected: 'matched'
# './parrot --gc-debug "/usr/src/parrot/t/compilers/pge/p6regex/01-regex_118.pir"' failed with exit code 1
# Looks like you failed 1 test of 494.

The attached patch seems to take care of this. Is this a reasonable way
to do it?

-- Bob Rogers
http://rgrjr.dyndns.org/

p6regex-no-icu.patch

Patrick R. Michaud

unread,
Jul 23, 2006, 1:09:00 PM7/23/06
to Bob Rogers, parrot-...@perl.org
On Sat, Jul 22, 2006 at 08:54:36PM -0400, Bob Rogers wrote:
Content-Description: message body text

> After building Parrot without ICU, 01-regex.t test 118 fails as
> follows:
> t/compilers/pge/p6regex/01-regex.........
> # Failed test (t/compilers/pge/p6regex/01-regex.t at line 59)
> # got: 'no ICU lib loaded
> The attached patch seems to take care of this. Is this a reasonable way
> to do it?

Looks perfect. Applied (r13457), thanks.

Pm

0 new messages