[perl #40998] [PATCH] Fix build error on Win32

[Nikolay Ananiev]

# New Ticket Created by "Nikolay Ananiev"
# Please include the string: [perl #40998]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40998 >

When build_dir contains spaces the build process fails.
The fix is to translate build_dir to a short path name.

[Ron Blaschke]

In my opinion it would be better to escape/quote the relevant paths
properly. I think the short file names were introduced for backwards
compatibility, as a kludge. Besides, they are ugly to read. ;-)

Ron

[Nikolay Ananiev]

"Ron Blaschke" <mailin...@rblasch.org> wrote in message
news:456C3E36...@rblasch.org...

If we use quotes, we'll have to refactor some of the scripts in the build
tree,
because there are many concatenations and currently they won't work
if we use quotes on build_dir. There's one more way. We can check build_dir
and use short path names only if there are spaces.

[Nikolay Ananiev]

OK, so no one seems interested.
Anyway, the attached patch in this message is a
better version of the previous one.
It checks for a white space in build_dir and makes the value
short path only when a space exists.

"Nikolay Ananiev" <ana...@thegdb.com> wrote in message
news:ekjf93$7vt$1...@sea.gmane.org...

[jnthn@jnthn.net via RT]

On Fri Dec 01 11:31:22 2006, ana...@thegdb.com wrote:
> OK, so no one seems interested.
>

Certainly on my part, lack of time rather than lack of interest.

> Anyway, the attached patch in this message is a
> better version of the previous one.
> It checks for a white space in build_dir and makes the value
> short path only when a space exists.
>

Thank you, applied in r16120.

While I agree that quoting paths is probably a nicer solution, this
patch is here now and deals with the problem at hand.

Thanks again - take care,

Jonathan