Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[perl #41163] [PATCH] suppress uninitialized value warning in config/inter/yacc.pm

9 views
Skip to first unread message

Lee Duhem

unread,
Jan 2, 2007, 11:36:13 AM1/2/07
to bugs-bi...@rt.perl.org
# New Ticket Created by "Lee Duhem"
# Please include the string: [perl #41163]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41163 >


This patch suppress some uninitialized value warning in config/inter/yacc.pm
when use --maintainer option at configure.

$ diffstat /tmp/yacc.patch
yacc.pm | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)

yacc.patch

Jonathan Worthington

unread,
Jan 4, 2007, 5:37:51 PM1/4/07
to perl6-i...@perl.org
Lee Duhem (via RT) wrote:
> This patch suppress some uninitialized value warning in config/inter/yacc.pm when use --maintainer option at configure.
>
I'm kinda concerned about what will happen if $3 was 0 (and was meant to
be). Perhaps it should be:

$prog_patch = defined $3 ? $3 : "";

Agree?

Thanks,

Jonathan

Lee Duhem

unread,
Jan 5, 2007, 12:20:45 AM1/5/07
to perl6-i...@perl.org

$3 come from line 88 of config/inter/yacc.pm
if ( $stdout =~ /Bison .*? (\d+) \. (\d+) (\w)?/x ) {

and I'm try this under Perl 5.8.8, and C<use warnings; use strict;>,
not get any warning about uninitialized value or similar.

But anyway, your advice is better than my patch. Please apply this
and I'll close [perl #41163].

Thanks.

Lee

0 new messages