Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: [perl #39868] [CAGE] convert C<BEGIN { plan tests => NN; }> to C<use Parrot::Test tests => NN;>

4 views
Skip to first unread message

Nuno Carvalho

unread,
Aug 18, 2006, 12:37:16 PM8/18/06
to perl6-i...@perl.org
(i initially posted this on RT, but since posts made by guests seem
not to get forwarded to the list here it is, only hope this message
goes into the right place)

Hi all,

I have applied the patch attatched to this ticket. Here's the outcome:

1) before the patch i did:

$ make test 2>&1 | tee test_before_patch

2) applied the patch (only a couple of problems, not a big deal):

$ patch -p0 < BEGIN-t.patch
(patching file ...)
can't find file to patch at input line 404
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: t/pmc/none.t
|===================================================================
|--- t/pmc/none.t (revision 13607)
|+++ t/pmc/none.t (working copy)
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
(patching file ...)
Hunk #2 FAILED at 67.
1 out of 2 hunks FAILED -- saving rejects to file
t/compilers/tge/parser.t.rej
(patching file ...)

3) after appliyng the patch i ran make test again:

$ make test 2>&1 | tee test_after_patch

4) and then i got the test differences:

$ diff test_before_patch test_after_patch
258c258,264
< t/compilers/tge/parser...................ok
---
> t/compilers/tge/parser...................You tried to plan twice!
Second plan at t/compilers/tge/parser.t line 92
> BEGIN failed--compilation aborted at t/compilers/tge/parser.t line 92.
> # Looks like your test died before it could output anything.
> dubious
> Test returned status 255 (wstat 65280, 0xff00)
> DIED. FAILED test 1
> Failed 1/1 tests, 0.00% okay
350c356
< Failed Test Stat Wstat Total Fail Failed List of Failed
---
> Failed Test Stat Wstat Total Fail Failed List of Failed
352,353c358,360
< t/examples/library.t 1 256 4 1 25.00% 3
< t/library/pcre.t 1 256 1 1 100.00% 1
---
> t/compilers/tge/parser.t 255 65280 1 2 200.00% 1
> t/examples/library.t 1 256 4 1 25.00% 3
> t/library/pcre.t 1 256 1 1 100.00% 1
355c362
< Failed 2/246 test scripts, 99.19% okay. 2/6710 subtests failed, 99.97%
okay.
---
> Failed 3/246 test scripts, 98.78% okay. 3/6709 subtests failed, 99.96%
okay.

It revealed some problems in the patch, but nothing that can't be fixed.

Just my 2cents,

0 new messages