[perl #39483] [TODO] fix PGE::OpTable comments, test.

[Will Coleda]

# New Ticket Created by Will Coleda
# Please include the string: [perl #39483]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=39483 >

This is a valid PGE::OpTable grammar:

grammar _Tcl::Grammar::Expr;

##proto 'prefix:-' is precedence('1=') {...}

...

This is not:

grammar _Tcl::Grammar::Expr;

#proto 'prefix:-' is precedence('1=') {...}

...

Apparently the double # is needed for comments.

Also, need to test comment handling in t/compilers/pge/03-optable.t

--
Will "Coke" Coleda
wi...@coleda.com

[Patrick R. Michaud]

On Thu, Jun 15, 2006 at 07:58:39AM -0700, Will Coleda wrote:
>
> This is a valid PGE::OpTable grammar:
>
> grammar _Tcl::Grammar::Expr;
>
> ##proto 'prefix:-' is precedence('1=') {...}
>
> ...
>
> This is not:
>
> grammar _Tcl::Grammar::Expr;
>
> #proto 'prefix:-' is precedence('1=') {...}

Are you referring to input files for pgc here?

> Apparently the double # is needed for comments.

Shouldn't be. Both versions compile just fine for me on my
system (r12990) and appear recognize that the leading # is a comment.
So, there must be something else happening here.

> Also, need to test comment handling in t/compilers/pge/03-optable.t

PGE::OPTable isn't normally responsible for parsing comments
(except perhaps as a skip between tokens, depending on the "ws"
rule). I'm guessing you're looking for testing comment handling
in pgc.pir.

Thanks!

Pm