Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[perl #40394] [PATCH] Added a test for multiple codas to t/codingstd/code_coda.t

7 views
Skip to first unread message

Paul Cochrane

unread,
Sep 21, 2006, 8:34:32 PM9/21/06
to bugs-bi...@rt.perl.org
# New Ticket Created by "Paul Cochrane"
# Please include the string: [perl #40394]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40394 >


Hi,

This patch gets code_coda.t to test for multiply-defined codas (for
those cases when a file append or automated tool adds a coda
unnecessarily). I have a feeling it's not pretty code, but my perl
foo is only slowly improving.

Regards,

Paul

Files affected by this patch:
parrot/t/codingstd/code_coda.t

code_coda_t.patch

Jerry Gay

unread,
Sep 22, 2006, 2:20:31 PM9/22/06
to perl6-i...@perl.org, bugs-bi...@rt.perl.org
On 9/21/06, via RT Paul Cochrane <parrotbug...@parrotcode.org> wrote:
> This patch gets code_coda.t to test for multiply-defined codas (for
> those cases when a file append or automated tool adds a coda
> unnecessarily). I have a feeling it's not pretty code, but my perl
> foo is only slowly improving.
>
great idea for the second test. i modified this patch a bit before
applying as r14686. specifically, i
~ modified plan to correct number of tests
~ renamed existing array @comments to @no_coda to better reflect use
~ simplified search for multiple codas

i think you might learn a neat trick for extracting a count of matches
(without using grep) from a regex if you look at the diff. thanks, and
more patches welcome! :)
~jerry

0 new messages