[PATCH] CYG23-544-stat (was [PATCH] Re: cando for cygwin)

[Reini Urban]

Attached is the stable cygwin patch for root filetests (gid 0 root <=>
gid 544 Administrators).

2009/8/13 Reini Urban <rur...@x-ray.at>:
> 2009/8/12 Jan Dubois <ja...@activestate.com>:
>> On Tue, 11 Aug 2009, Reini Urban wrote:
>>> 2009/8/11 Ben Morrow <b...@morrow.me.uk>:
>>> > Quoth rur...@x-ray.at (Reini Urban):
>>> >>
>>> >> I got a bugreport on cygwin by a user who forgot about use filetest 'access'.
>>> >> He was a Administrator and worried about the wrong writable flag, because
>>> >> access() is not called per default on -w checks
>>> >>
>>> >> So I added the gid 544 check to cando(), which is the short analog to
>>> >> unix root.
>>> >
>>> > This patch doesn't apply to blead: Perl_cando doesn't currently have a
>>> > __CYGWIN__ branch. The attached patch fixes this and also updates the
>>> > Perl analogue to Perl_cando in File::stat. It's untested, since I don't
>>> > have Cygwin.
>>>
>>> Thanks Ben, this is what I meant to send, yes.
>>
>> Note that Ben did not yet commit the patch.  I assume he waiting for you to
>> explicitly confirm that you also tested the File::stat change he made.
>
> Yes, thanks for the reminder. Ben's patch is still in my stack.
>
> Upstream I got more info about cygwin's behaviour and it looks like the
> real fix will be more expensive, check for ingroup 544, almost the
> costs for access().
>
> I don't know yet what we should use on cygwin and I will need
> more time to test both ways.
>  gid == 544 or ingroup(544)
> --
> Reini Urban
>

--
Reini Urban
http://phpwiki.org/ http://murbreak.at/

[H.Merijn Brand]

On Thu, 14 Jan 2010 12:31:58 +0100, Reini Urban <rur...@x-ray.at> wrote:

> Attached is the stable cygwin patch for root filetests (gid 0 root <=>
> gid 544 Administrators).

Thanks, applied as b595cd4b73a6e1bd45865d6446c34d4019c740d1

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/