Re: [perl.git] branch blead, updated. GitLive-blead-528-g2770a1c
Adriano Ferreira
> In perl.git, the branch blead has been updated
>
> <
> http://perl5.git.perl.org/perl.git/commitdiff/2770a1ce2934f4277de13f4f795ba41c86bf1646?hp=b3f1e0ca82d294b0623e703c44104244c31cb9ef
> >
>
> - Log -----------------------------------------------------------------
> commit 2770a1ce2934f4277de13f4f795ba41c86bf1646
> Author: Nicholas Clark <ni...@ccl4.org>
> Date: Sat Feb 7 15:47:15 2009 +0000
>
> Carp 1.05 shipped with 5.8.8. Remove work-around for pre 1.05.
> -----------------------------------------------------------------------
>
> Summary of changes:
> lib/Exporter.pm | 5 +----
> lib/Exporter/Heavy.pm | 3 ---
> 2 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/lib/Exporter.pm b/lib/Exporter.pm
> index 9e1c1ea..c18a13a 100644
> --- a/lib/Exporter.pm
> +++ b/lib/Exporter.pm
> @@ -9,12 +9,9 @@ require 5.006;
> our $Debug = 0;
> our $ExportLevel = 0;
> our $Verbose ||= 0;
> -our $VERSION = '5.63';
> +our $VERSION = '5.64';
> our (%Cache);
>
> -# Carp 1.05+ does this now for us, but we may be running with an old Carp
> -$Carp::Internal{Exporter}++;
> -
>
Damn. I know I am quite late with this change.
But I can't take this change into Exporter in CPAN. I would need to declare
a dependency on Carp 1.05, but Carp is not a dual life module.
Thoughts?
Adriano
> sub as_heavy {
> require Exporter::Heavy;
> # Unfortunately, this does not work if the caller is aliased as *name =
> \&foo
> diff --git a/lib/Exporter/Heavy.pm b/lib/Exporter/Heavy.pm
> index d8dff22..724028a 100644
> --- a/lib/Exporter/Heavy.pm
> +++ b/lib/Exporter/Heavy.pm
> @@ -6,9 +6,6 @@ no strict 'refs';
> # On one line so MakeMaker will see it.
> require Exporter; our $VERSION = $Exporter::VERSION;
>
> -# Carp 1.05+ does this now for us, but we may be running with an old Carp
> -$Carp::Internal{'Exporter::Heavy'}++;
> -
> =head1 NAME
>
> Exporter::Heavy - Exporter guts
>
> --
> Perl5 Master Repository
>
Steffen Mueller
Adriano Ferreira wrote:
> But I can't take this change into Exporter in CPAN. I would need to declare
> a dependency on Carp 1.05, but Carp is not a dual life module.
>
> Thoughts?
Are there reasons not to dual-life Carp?
Cheers,
Steffen
Nicholas Clark
> On Sat, Feb 7, 2009 at 12:47 PM, Nicholas Clark <ni...@ccl4.org> wrote:
>
> > In perl.git, the branch blead has been updated
> > - Log -----------------------------------------------------------------
The fact that I bumped $VERSION from 5.63 to 5.64 rather than a dev release
shows that I didn't even realise that Exporter was dual-life.
On Thu, Oct 01, 2009 at 04:48:48PM +0200, Steffen Mueller wrote:
> Hi Adriano,
>
> Adriano Ferreira wrote:
> >But I can't take this change into Exporter in CPAN. I would need to declare
> >a dependency on Carp 1.05, but Carp is not a dual life module.
> >
> >Thoughts?
>
> Are there reasons not to dual-life Carp?
It's as intertwined with the core build process as Exporter is.
Exporter is sufficiently entangled that I don't think that it's viable to move
it to cpan/
Carp would be the same.
Solutions I can think of:
1: Dual life Carp too. (I don't like this)
2: Roll this change back, and have Exporter 5.65 be the same as 5.63
3: Make Exporter on CPAN dependant on perl 5.8.8 or later
I don't see 3) as crazy. How many people/companies have policies that allow/the
inclination to upgrade Exporter, but not to upgrade from a perl 3.5 years
and 2 versions out of date?
Nicholas Clark
Zefram
>> > -# Carp 1.05+ does this now for us, but we may be running with an old Carp
>> > -$Carp::Internal{Exporter}++;
This change is faulty. If Exporter is going to rely on Carp 1.05+,
it should do a "Carp->VERSION(1.05)" after "require Carp".
>1: Dual life Carp too. (I don't like this)
I like this. If versions of Carp are significant, for feature reasons,
it makes perfect sense for Carp to be independently upgradable. New Carp
will work fine on old core, won't it?
>2: Roll this change back, and have Exporter 5.65 be the same as 5.63
This is sane. I'm neutral on whether Exporter should actually depend
on newer versions of anything.
>3: Make Exporter on CPAN dependant on perl 5.8.8 or later
Eww. The dependency is on Carp, not on the perl core.
-zefram