Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

29044 broke Fatal.pm

7 views
Skip to first unread message

Andreas J. Koenig

unread,
Mar 18, 2007, 4:26:58 AM3/18/07
to The Perl5 Porters Mailing List, mba...@users.sourceforge.net
bleadperl's Fatal.pm chokes at the _ prototype:

% perl -MFatal=sin
Unknown prototype letters: "_" at /home/src/perl/repoperls/installed-perls/perl/pV9JsIn/perl-5.8.0@30610/lib/5.9.5/Fatal.pm line 44.
BEGIN failed--compilation aborted.


This patch seems all that's needed. Thanks to Mattia for using Fatal
with 'mkdir' to find this bug.

--- lib/Fatal.pm~ 2007-03-17 20:39:28.000000000 +0100
+++ lib/Fatal.pm 2007-03-18 07:39:02.000000000 +0100
@@ -38,7 +38,7 @@
$n++;
push(@out1,[$n,@out]) if $seen_semi;
push(@out, $1 . "{\$_[$n]}"), next if $proto =~ s/^\s*\\([\@%\$\&])//;
- push(@out, "\$_[$n]"), next if $proto =~ s/^\s*([*\$&])//;
+ push(@out, "\$_[$n]"), next if $proto =~ s/^\s*([_*\$&])//;
push(@out, "\@_[$n..\$#_]"), last if $proto =~ s/^\s*(;\s*)?\@//;
$seen_semi = 1, $n--, next if $proto =~ s/^\s*;//; # XXXX ????
die "Unknown prototype letters: \"$proto\"";
--- lib/Fatal.t~ 2002-06-01 19:03:17.000000000 +0200
+++ lib/Fatal.t 2007-03-18 07:38:25.000000000 +0100
@@ -7,7 +7,7 @@
}

use strict;
-use Fatal qw(open close :void opendir);
+use Fatal qw(open close :void opendir sin);

my $i = 1;
eval { open FOO, '<lkjqweriuapofukndajsdlfjnvcvn' };


--
andreas

Nicholas Clark

unread,
Mar 18, 2007, 3:45:30 PM3/18/07
to Andreas J. Koenig, The Perl5 Porters Mailing List, mba...@users.sourceforge.net
On Sun, Mar 18, 2007 at 09:26:58AM +0100, Andreas J. Koenig wrote:
> bleadperl's Fatal.pm chokes at the _ prototype:
>
> % perl -MFatal=sin
> Unknown prototype letters: "_" at /home/src/perl/repoperls/installed-perls/perl/pV9JsIn/perl-5.8.0@30610/lib/5.9.5/Fatal.pm line 44.
> BEGIN failed--compilation aborted.
>
>
> This patch seems all that's needed. Thanks to Mattia for using Fatal
> with 'mkdir' to find this bug.

Thanks, applied (change 30614)

Nicholas Clark

0 new messages