Prerequisite version too low Need 1.50 have 1.5

[Gabor Szabo]

Hi,

While trying to install Module-Packaged-0.86.tar.gz on Windows it had
a test failure
but it has not been reported because of this.

I am not sure what does that mean. Is the version number comparison in
CPAN::Reporter
broken or should Module-Packaged declare Sort::Versions 1.5 as prerequisite?


CPAN::Reporter: test results were not valid, Prerequisite version too low:
requires:

Module Need Have
------------------------------ ---- -----
App::Cache 0 0.37
Class::Accessor::Chained::Fast 0 0
Compress::Zlib 0 2.059
IO::File 1.08 1.14
IO::String 0 1.08
IO::Zlib 1.01 1.10
LWP::Simple 1.38 6.00
Parse::CPAN::Packages 2.20 2.38
Parse::Debian::Packages 0.01 0.03
! Sort::Versions 1.50 1.5
Storable 0 2.39
Test::More 0.47 0.98


regards
Gabor

[David Golden]

On Fri, Jan 4, 2013 at 8:28 AM, Gabor Szabo <ga...@szabgab.com> wrote:
> I am not sure what does that mean. Is the version number comparison in
> CPAN::Reporter
> broken or should Module-Packaged declare Sort::Versions 1.5 as prerequisite?

CPAN::Reporter uses CPAN::Version for version comparisions. (I wish
we could use version.pm, but we are trying to be backwards compatible
and not force older perls to have version.pm installed.)

So whatever it's doing for version comparison in CPAN::Version::vcmp()
is to blame. When I see 1.50 != 1.5, I immediately start thinking
about floating point issues. Was this a 64 bit machine by any chance?

David

--
David Golden <x...@xdg.me>
Take back your inbox! → http://www.bunchmail.com/
Twitter/IRC: @xdg

[David Golden]

On Fri, Jan 4, 2013 at 11:46 AM, Lars Thegler <la...@thegler.dk> wrote:
> Yes, version.pm says "1.50" == "1.5". But both CPAN::Version and
> Sort::Versions disagree. Who is to say which is correct? We could
> easily find lots and lots of people on the Internet disagreeing
> heartily on this matter :)

The only thing that matters is what perl thinks:

use Sort::Versions 1.50;
use Sort::Versions 1.5;

As of Perl v5.10, it uses the same code internally as version.pm
(modulo version.pm bug fixes over time), so they should be considered
equivalent, even when $Sort::Versions::VERSION="1.5". (I.e. a
string.)

Unfortunately, we can't fix existing CPAN::Version on old Perls. We
could fix it and have CPAN::Reporter bump it's CPAN.pm prerequisite.
Or we could finally have CPAN::Reporter starting using version.pm.
Given that 5.8 is now well out of the support window, it's tempting to
finally use version.pm.

David

[Andreas Koenig]

David Golden <x...@xdg.me> writes:

> On Fri, Jan 4, 2013 at 8:28 AM, Gabor Szabo <ga...@szabgab.com> wrote:
>> I am not sure what does that mean. Is the version number comparison in
>> CPAN::Reporter
>> broken or should Module-Packaged declare Sort::Versions 1.5 as prerequisite?
>
> CPAN::Reporter uses CPAN::Version for version comparisions. (I wish
> we could use version.pm, but we are trying to be backwards compatible
> and not force older perls to have version.pm installed.)
>
> So whatever it's doing for version comparison in CPAN::Version::vcmp()
> is to blame. When I see 1.50 != 1.5, I immediately start thinking
> about floating point issues. Was this a 64 bit machine by any chance?

I don't think so. I believe this is even intentional.

% perl -MCPAN::Version -le 'print CPAN::Version->vcmp("1.5", "1.50")'
-1

When I see in the t/10version.t file:

1.57_00 1.57 1
1.5700 1.57 1

then I believe this was fully intentional. version.pm and CPAN::Version
are not compatible. Period. I was intending to switch to version.pm some
day but I'm more concerned about stability than compatibility. Version
numbers are still not boring enough. Sigh.

--
andreas

[Lars Thegler]

Or it might be a tongue-in-cheek joke, especially since it is about
Sort::Versions - the one bit of code in the mix, which cares about
such things...

Seriously, it's a bug in the prerequisite list in Build.PL of
Module-Packaged. There never was a '1.50' version of Sort::Versions.

/Lars

[Lars Thegler]

Yes, version.pm says "1.50" == "1.5". But both CPAN::Version and
Sort::Versions disagree. Who is to say which is correct? We could
easily find lots and lots of people on the Internet disagreeing
heartily on this matter :)

I think version numbers with trailing zeroes suck for this exact
reason. Just fix the prerequisite list, and get on with life.

/Lars